Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add (*) -> added depart/arrive date for employe #1

Merged
merged 1 commit into from
Jan 6, 2023
Merged

add (*) -> added depart/arrive date for employe #1

merged 1 commit into from
Jan 6, 2023

Conversation

withs
Copy link
Collaborator

@withs withs commented Jan 6, 2023 •
edited
Loading

code pour la partit ajout de date:

  • ajout de 2 variables dans la classe Employer, getter et setter
  • ajout test pour ces 2 variables
  • modification du constructeur et les endroit ou ils sont utiliser

@withs withs self-assigned this Jan 6, 2023
@withs
Copy link
Collaborator Author

withs commented Jan 6, 2023

@Surfingchicken @Lahuts checker si c'est ok pour vous et celui qui a les droit d'écriture peux merger

@withs
Copy link
Collaborator Author

withs commented Jan 6, 2023

peut etres changer la date de depart en Optional au lieu d'avoir une valeur null

Lahuts
Lahuts reviewed Jan 6, 2023
View reviewed changes
Copy link
Owner

@Lahuts Lahuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request change 👍
juste voir pour instanciation de Employee avec null

@Lahuts Lahuts merged commit 8e64e29 into master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Surfingchicken Surfingchicken Surfingchicken approved these changes

@Lahuts Lahuts Lahuts approved these changes

Assignees

@withs withs

Labels
need review
Projects
None yet
Milestone
No milestone
3 participants
@withs @Surfingchicken @Lahuts