Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customise feed titles #15

Merged
merged 6 commits into from
Jul 20, 2020
Merged

Conversation

shaneHowearth
Copy link

Added a field to the database that is populated with the display name for the feed.

The config file feeds strings will be split on the '~' char, with the first section being the url to fetch, and the second (optional) section being the name displayed in the window.

This only changes the name in the feeds window, not the name in the article window - please let me know if a change is preferred

This change will not work with an existing copy of the database, to use this version will require execution of the following command (assuming this is where the database is on your local system) mv ~/.local/share/gorss/gorss.db{,.bkup}

Currently the display is tightly coupled to the fetching of the URL, I feel that this should be re-architected, but this PR may not be the right place to do that.

@Lallassu
Copy link
Owner

I tried it out and it looks good! ping me when it's ready to merge.

@shaneHowearth
Copy link
Author

@Lallassu I've tidied up the PR a little, split it into several commits, to try and make the change clearer(although the second and third commit have a bit of a mix... but I don't want to risk losing stuff)

If you would like mt to do any more to this PR feel free to let me know

@shaneHowearth
Copy link
Author

Hrm, this is going to break things for clients that have existing feeds that have ~ in the URL ( as seen in the issue discussion) - I want to put a hold on this from being merged until a more robust solution is worked out.

The natural inclination for me is to write a space then a ~between the URL and the optional name, which is what I think I will change the delimiter to.

@shaneHowearth shaneHowearth changed the title WIP - Customise feed titles Customise feed titles Jul 19, 2020
@shaneHowearth
Copy link
Author

@Lallassu Assuming this passes your tests, I'm happy for it to be merged now

@shaneHowearth
Copy link
Author

Hrm, this will break peoples' existing database, should I write something to catch that (can a sqllite table be altered)? Or is it better to release this with a note on the database needing a mv ~/.local/share/gorss/gorss.db{,-old}

@Lallassu
Copy link
Owner

Hrm, this will break peoples' existing database, should I write something to catch that (can a sqllite table be altered)? Or is it better to release this with a note on the database needing a mv ~/.local/share/gorss/gorss.db{,-old}

I think a mv will do and include this in a major release later on. Like a 1.0.0. I've not been that strict to versions yet, but I'll start with correct versioning and that will basically solve any breaking change.

@Lallassu Lallassu merged commit d576ff4 into Lallassu:master Jul 20, 2020
@shaneHowearth shaneHowearth deleted the customise_feed_titles branch July 20, 2020 06:54
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants