-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customise feed titles #15
Customise feed titles #15
Conversation
I tried it out and it looks good! ping me when it's ready to merge. |
6c1668a
to
964df59
Compare
964df59
to
f9206e3
Compare
f9206e3
to
36faf89
Compare
@Lallassu I've tidied up the PR a little, split it into several commits, to try and make the change clearer(although the second and third commit have a bit of a mix... but I don't want to risk losing stuff) If you would like mt to do any more to this PR feel free to let me know |
Hrm, this is going to break things for clients that have existing feeds that have ~ in the URL ( as seen in the issue discussion) - I want to put a hold on this from being merged until a more robust solution is worked out. The natural inclination for me is to write a space then a ~between the URL and the optional name, which is what I think I will change the delimiter to. |
d7220ee
to
f21e0ec
Compare
f21e0ec
to
8b0fea4
Compare
@Lallassu Assuming this passes your tests, I'm happy for it to be merged now |
Hrm, this will break peoples' existing database, should I write something to catch that (can a sqllite table be altered)? Or is it better to release this with a note on the database needing a |
I think a |
Added a field to the database that is populated with the display name for the feed.
The config file feeds strings will be split on the '~' char, with the first section being the url to fetch, and the second (optional) section being the name displayed in the window.
This only changes the name in the feeds window, not the name in the article window - please let me know if a change is preferred
This change will not work with an existing copy of the database, to use this version will require execution of the following command (assuming this is where the database is on your local system)
mv ~/.local/share/gorss/gorss.db{,.bkup}
Currently the display is tightly coupled to the fetching of the URL, I feel that this should be re-architected, but this PR may not be the right place to do that.