Fix chipped textures #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The texture paths used by Chipped did not match any of the formats tried by this mod. These changes introduce support for an alternate texture path based on Chipped to resolve these issues. It doesn't seem to entirely resolve issues with the top texture for Chipped mushroom stems but there are no obvious missing textures when scanning the EMI images and a proper fix may be fiddly. The fallback handling for missing log textures has also been changed to call the normal plank texture function, as it was calling a more basic function that didn't try alternate paths, leading to failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installed this mod alongside Chipped, found lots of missing textures, decided to patch it.
The problem was the texture paths used by Chipped did not match any of the formats tried by this mod. These changes introduce support for an alternate texture path based on Chipped to resolve these issues.
It doesn't seem to entirely resolve issues with the top texture for Chipped mushroom stems but there are no obvious missing textures when scanning the EMI images and a proper fix may be fiddly.
The fallback handling for missing log textures has also been changed to call the normal plank texture function, as it was calling a more basic function that didn't try alternate paths, leading to failures.