[#79] Refund transaction documentation #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szerepak
force-pushed
the
cl-79-update-documentation-refund-transaction
branch
2 times, most recently
from
9e1c0e5
to
ab180e0
Compare
trojkat
reviewed
Mar 16, 2018
docs/source/refund.md
Outdated
| 'secret_hash': 'ce4209765f76e8c29bbcdc26c33746a0dc6feebe986444f8326008808ece2c33', | ||
| 'size': 255, | ||
| 'size_text': '255 bytes', | ||
| 'transaction_hash': 'cc37c5a6f66f24b33e85c5ac2210488873ac61dad4e3098d7a6b35f7f55ff579', |
There was a problem hiding this comment.
transaction_hash was changed 3 days ago (d237ce7) to transaction_address + contract_address was added.
szerepak
force-pushed
the
cl-79-update-documentation-refund-transaction
branch
from
ab180e0
to
2bdbe1d
Compare
szerepak
changed the title
szerepak
force-pushed
the
cl-79-update-documentation-refund-transaction
branch
3 times, most recently
from
855a66e
to
25f272a
Compare
szerepak
changed the title
szerepak
force-pushed
the
cl-79-update-documentation-refund-transaction
branch
from
25f272a
to
4b18be6
Compare
pafff
approved these changes
Mar 21, 2018
clove/network/bitcoin/contract.py
Outdated
| @@ -86,7 +86,7 @@ def redeem(self, wallet, secret): | |||
| def refund(self, wallet): | |||
| if self.locktime > datetime.utcnow(): | |||
| locktime_string = self.locktime.strftime('%Y-%m-%d %H:%M:%S') | |||
| raise RuntimeError(f"This contract is still valid! It can't be refunded until {locktime_string}.") | |||
| raise RuntimeError(f"This contract is still valid! It can't be refunded until {locktime_string}. UTC") | |||
docs/source/refund.md
Outdated
| refund_transaction = alice_contract.refund(alice_ltc_wallet) | ||
| RuntimeError: This contract is still valid! It can't be refunded until 2018-03-21 14:27:19 UTC. | ||
|
|
||
| Oops! Something wen wrong! Contract is still valid! Alice was a bit impatient, wasn't she? |
docs/source/refund.md
Outdated
| refund_transaction = bob_contract.refund(bob_mona_wallet) | ||
| RuntimeError: This contract is still valid! It can't be refunded until 2018-03-20 14:37:01 UTC. | ||
|
|
||
| Oops! Something wen wrong! Contract is still valid! Bob was a bit impatient, wasn't he? |
szerepak
force-pushed
the
cl-79-update-documentation-refund-transaction
branch
from
4b18be6
to
f09f4d6
Compare
trojkat
approved these changes
Mar 22, 2018
trojkat
force-pushed
the
cl-79-update-documentation-refund-transaction
branch
from
f09f4d6
to
26cd513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.