-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#79] Refund transaction documentation #110
Conversation
9e1c0e5
to
ab180e0
Compare
docs/source/refund.md
Outdated
'secret_hash': 'ce4209765f76e8c29bbcdc26c33746a0dc6feebe986444f8326008808ece2c33', | ||
'size': 255, | ||
'size_text': '255 bytes', | ||
'transaction_hash': 'cc37c5a6f66f24b33e85c5ac2210488873ac61dad4e3098d7a6b35f7f55ff579', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transaction_hash
was changed 3 days ago (d237ce7) to transaction_address
+ contract_address
was added.
ab180e0
to
2bdbe1d
Compare
855a66e
to
25f272a
Compare
25f272a
to
4b18be6
Compare
clove/network/bitcoin/contract.py
Outdated
@@ -86,7 +86,7 @@ def redeem(self, wallet, secret): | |||
def refund(self, wallet): | |||
if self.locktime > datetime.utcnow(): | |||
locktime_string = self.locktime.strftime('%Y-%m-%d %H:%M:%S') | |||
raise RuntimeError(f"This contract is still valid! It can't be refunded until {locktime_string}.") | |||
raise RuntimeError(f"This contract is still valid! It can't be refunded until {locktime_string}. UTC") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the dot to the end.
docs/source/refund.md
Outdated
refund_transaction = alice_contract.refund(alice_ltc_wallet) | ||
RuntimeError: This contract is still valid! It can't be refunded until 2018-03-21 14:27:19 UTC. | ||
|
||
Oops! Something wen wrong! Contract is still valid! Alice was a bit impatient, wasn't she? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went
docs/source/refund.md
Outdated
refund_transaction = bob_contract.refund(bob_mona_wallet) | ||
RuntimeError: This contract is still valid! It can't be refunded until 2018-03-20 14:37:01 UTC. | ||
|
||
Oops! Something wen wrong! Contract is still valid! Bob was a bit impatient, wasn't he? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went
4b18be6
to
f09f4d6
Compare
f09f4d6
to
26cd513
Compare
No description provided.