Patch 4 #2
Merged
Patch 4 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also upgrade `lint-staged`, because it's broken for some reason - reformat - lint - remove `prettier-eslint-cli` - update formatting command to handle JSON & YAML files via prettier, and eslint for everything else - update `.lintstagedrc` to deal as well test file changes are related to deprecations of various `assert` methods
also use exact `yargs-unparser` version
- Remove unused variables to avoid problems with mochajs#237 (and their associated inline ESLint directives) - Use existing ESLint rules (`no-restricted-globals`, `no-restricted-modules` and `no-restricted-syntax`) to disallow global timer access. - Removed "poison pill" tests in `test/unit/runnable.spec.js`. For those rules, our config applies only to `bin/*` and `lib/**/*.js`. - `no-restricted-globals`: Disallow bare references (including calls) to timers like `setTimeout`. - `no-restricted-modules`: Disallow use of Node.js' `timers` module to get around the above restriction. - `no-restricted-syntax`: - Disallow calls of `global.setTimeout` and other timers - Disallow `new global.Date()` - Disallow any expressions involving `global.Date.*`, `global.setTimeout.*` and other timers - add more files to markdown linting - reorg tests, remove `fs` test from jsapi tests
* runner.js: delete second end emit * tests * documentation * runner.js * tests: corrections closes mochajs#3398, closes mochajs#3598, closes mochajs#3457, closes mochajs#3617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.