Add support for DLT with Pulsar #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
commented
Oct 18, 2023
| @@ -145,7 +145,7 @@ public Topic getTopicByName(String name) { | |||
|
|
|||
| public TopicDefinition getTopicDefinitionByName(String name) { | |||
| return topics.entrySet().stream() | |||
| .filter(e -> e.getKey().getName().equals(name)) | |||
| .filter(e -> e.getValue().topicName().equals(name)) | |||
There was a problem hiding this comment.
We lookup by topic name instead of TopicDefinition name, Is it OK?
There was a problem hiding this comment.
if all the tests are passing then I guess that it is okay
cbornet
commented
Oct 18, 2023
| @@ -342,7 +342,7 @@ private Topic buildImplicitTopicForDeadletterQueue( | |||
| StreamingClusterRuntime streamingClusterRuntime, | |||
| ExecutionPlan physicalApplicationInstance) { | |||
| // connecting two agents requires an intermediate topic | |||
| String name = connection.topicName() + "-deadletter"; | |||
| String name = inputTopicDefinition.getName() + "-deadletter"; | |||
There was a problem hiding this comment.
We use the TopicDefinition name instead of the topic name. Is it OK?
There was a problem hiding this comment.
if all the tests are passing then I guess that it is okay
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.