-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DLT with Pulsar #618
Conversation
@@ -145,7 +145,7 @@ public Topic getTopicByName(String name) { | |||
|
|||
public TopicDefinition getTopicDefinitionByName(String name) { | |||
return topics.entrySet().stream() | |||
.filter(e -> e.getKey().getName().equals(name)) | |||
.filter(e -> e.getValue().topicName().equals(name)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We lookup by topic name instead of TopicDefinition name, Is it OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if all the tests are passing then I guess that it is okay
@@ -342,7 +342,7 @@ private Topic buildImplicitTopicForDeadletterQueue( | |||
StreamingClusterRuntime streamingClusterRuntime, | |||
ExecutionPlan physicalApplicationInstance) { | |||
// connecting two agents requires an intermediate topic | |||
String name = connection.topicName() + "-deadletter"; | |||
String name = inputTopicDefinition.getName() + "-deadletter"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the TopicDefinition name instead of the topic name. Is it OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if all the tests are passing then I guess that it is okay
No description provided.