-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels hard to read against dark census poly's #162
Labels
focus: 📜 documentation📜
Documentation tasks such as Gdocs, inline code comments, wiki, etc.
type: 🔧 maintenance🔧
Catch-all for "other" tasks (e.g. most docs, refactoring). Not a bug nor new functionality.
Comments
Got it, will work with this, great documentation
… On Jan 8, 2021, at 12:40 PM, Jason Lampel ***@***.***> wrote:
Not really a bug, but just like the title says:
<https://user-images.githubusercontent.com/4974087/104044951-1809ac80-519b-11eb-9e29-7d6b58aa0b4a.png>
Resolution
I forgot about it, but this is actually controlled entirely in Airtable, and is meant to be tweaked by the data maintainers. This is what I was originally shooting for w/MB styles, but that didn't pan out and I switched to JS config, but ultimately shoved it all in Airtable with the intent that @rperlin-ela <https://github.com/rperlin-ela> (or @fiddleHeads <https://github.com/fiddleHeads> if we were still using MB styles) could edit as needed.
Ross, I created a view <https://airtable.com/tblOuDuPcU2prgTzP/viwyJ6g0HKJPbJMtO?blocks=hide> awhile ago for World Region, and the most relevant column to focus on is text-color. The text value just needs to be a valid color (e.g. a hex color, HSL, or named color like purple, although that's a bad idea). Most of them are hex colors but I would recommend using HSL instead (you can find converters online) since it is more intuitive than Rainmanning hex codes:
<https://user-images.githubusercontent.com/4974087/104045688-286e5700-519c-11eb-8e9b-fd25f4d2585b.png>
Specifically, the third parameter of HSL is "lightness", so just crank it down a bit until you get the result you want. You'll have to refresh the map each time, but you could do a handful of values then refresh to save time.
Example
Southern Europe, before had hsl(164, 17%, 52%):
<https://user-images.githubusercontent.com/4974087/104045815-594e8c00-519c-11eb-8edd-7373830953ae.png>
now with hsl(164, 17%, 32%) (note the lightness reduction by 20%):
<https://user-images.githubusercontent.com/4974087/104045978-9adf3700-519c-11eb-8825-0d42f236cbed.png>
or down to hsl(164, 17%, 22%) (another 10%):
<https://user-images.githubusercontent.com/4974087/104046171-e7c30d80-519c-11eb-9946-9a1e8b87cadc.png>
You can also play with the text-halo-color, which is the outline around the letters, just note that the only example I have is using hsla instead of hsl, in which the a is "alpha": 0 = transparent, 1 = opaque: hsla(164, 17%, 90%, 0.95)
If you make it pure white, it will probably stand out big time, but it might be a little intense.
Long-term
None of them are stellar options, but in lieu of a full-on second set of symbology (something that would also be required if we ever have a "dark" background map) and some code to back it up, that's all we've got for now.
Feel free to play around with it, per-record AT revisions got yer back. Also, this should all go in The Manual of course, so let's not close this issue as it's the only doc so far.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#162>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMNKB5CG2OE7G35J7ENCZZLSY47RLANCNFSM4V2X6LLA>.
|
Removing the bug label, and my documentation above belongs in whatever home we assign to the "skim through relevant GH issues" item in the SOW. I'll chuck it into something linkable or included with the "bare minimum dev documentation" issue. |
...which is #107 |
abettermap
added
focus: 📜 documentation📜
Documentation tasks such as Gdocs, inline code comments, wiki, etc.
type: 🔧 maintenance🔧
Catch-all for "other" tasks (e.g. most docs, refactoring). Not a bug nor new functionality.
and removed
type: 🐛 bug🐛
Something isn't working
labels
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
focus: 📜 documentation📜
Documentation tasks such as Gdocs, inline code comments, wiki, etc.
type: 🔧 maintenance🔧
Catch-all for "other" tasks (e.g. most docs, refactoring). Not a bug nor new functionality.
Not really a bug, but just like the title says:
Resolution
I forgot about it, but this is actually controlled entirely in Airtable, and is meant to be tweaked by the data maintainers. This is what I was originally shooting for w/MB styles, but that didn't pan out and I switched to JS config, but ultimately shoved it all in Airtable with the intent that @rperlin-ela (or @fiddleHeads if we were still using MB styles) could edit as needed.
Ross, I created a view awhile ago for World Region, and the most relevant column to focus on is
text-color
. The text value just needs to be a valid color (e.g. a hex color, HSL, or named color likepurple
, although that's a bad idea). Most of them are hex colors but I would recommend using HSL instead (you can find converters online) since it is more intuitive than Rainmanning hex codes:Specifically, the third parameter of HSL is "lightness", so just crank it down a bit until you get the result you want. You'll have to refresh the map each time, but you could do a handful of values then refresh to save time.
Example
Southern Europe, before had
hsl(164, 17%, 52%)
:now with
hsl(164, 17%, 32%)
(note the lightness reduction by 20%):or down to
hsl(164, 17%, 22%)
(another 10%):You can also play with the
text-halo-color
, which is the outline around the letters, just note that the only example I have is usinghsla
instead ofhsl
, in which thea
is "alpha": 0 = transparent, 1 = opaque:hsla(164, 17%, 90%, 0.95)
If you make it pure white, it will probably stand out big time, but it might be a little intense.
Long-term
None of them are stellar options, but in lieu of a full-on second set of symbology (something that would also be required if we ever have a "dark" background map) and some code to back it up, that's all we've got for now.
Feel free to play around with it, per-record AT revisions got yer back. Also, this should all go in The Manual of course, so let's not close this issue as it's the only doc so far.
The text was updated successfully, but these errors were encountered: