Add support for DateTimeImmutable

Lansoweb · Feb 10, 2015 · 48b3aab · 48b3aab
1 parent 8615f24
commit 48b3aab
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/library/Zend/Validator/Date.php b/library/Zend/Validator/Date.php
@@ -10,6 +10,7 @@
 namespace Zend\Validator;
 
 use DateTime;
+use DateTimeInterface;
 use Traversable;
 
 /**
@@ -127,7 +128,8 @@ public function isValid($value)
      */
     protected function convertToDateTime($param, $addErrors = true)
     {
-        if ($param instanceof DateTime) {
+        // @TODO: when minimum dependency will be PHP 5.5, we can only keep check against DateTimeInterface
+        if ($param instanceof DateTime || $param instanceof DateTimeInterface) {
             return $param;
         }
 

diff --git a/tests/ZendTest/Validator/DateTest.php b/tests/ZendTest/Validator/DateTest.php
@@ -10,6 +10,7 @@
 namespace ZendTest\Validator;
 
 use DateTime;
+use DateTimeImmutable;
 use stdClass;
 use Zend\Validator;
 
@@ -96,6 +97,15 @@ public function testBasic($input, $format, $result)
         $this->assertEquals($result, $this->validator->isValid($input));
     }
 
+    public function testDateTimeImmutable()
+    {
+        if (PHP_VERSION_ID < 50500) {
+            $this->markTestSkipped('`DateTimeImmutable` is only supported in PHP >=5.5.0');
+        }
+
+        $this->assertTrue($this->validator->isValid(new DateTimeImmutable()));
+    }
+
     /**
      * Ensures that getMessages() returns expected default value
      *