Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ReflectionException Class translator does not exist #1270

Merged
merged 6 commits into from
Mar 9, 2018
Merged

Fix for ReflectionException Class translator does not exist #1270

merged 6 commits into from
Mar 9, 2018

Conversation

DoDSoftware
Copy link
Contributor

Calling trans() here now throws ReflectionException Class translator does not exist.
Defaulting to "All " to avoid this issue. It's easy enough to change if the user needs to.

#1252 (comment)

Calling trans() here now throws ReflectionException Class translator does not exist
#1252 (comment)
Addresses issues with logic added in ## [3.3.11] - 2018-02-23 - added ```config('backpack.crud.page_length_menu')``` config variable;
Count could have lead to unexpected behaviour
@DoDSoftware
Copy link
Contributor Author

It seems this issue was introduced in:

[3.3.11] - 2018-02-23

  • added config('backpack.crud.page_length_menu') config variable;

Copy link
Member

@tabacitu tabacitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tabacitu tabacitu merged commit 0183d63 into Laravel-Backpack:master Mar 9, 2018
@welcome
Copy link

welcome bot commented Mar 9, 2018

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.
party

You should also receive an email inviting you to the Community Members team. That's where we, commited community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)

If you want to help out the community in other ways, you can:

  • give your opinion on other Github Issues & PRs;
  • chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
  • answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-)
Cheers!

--
Justin Case
The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!

@tabacitu
Copy link
Member

tabacitu commented Mar 9, 2018

OMG, thank you so much @DelightedD0D ! It is so weird that it does not trigger the error in the package config, but it does trigger it in the app config. I had no idea, and it did not come up in my testing. I just hope this didn't mess up too many people's first experience with Backpack. As I understand it, this triggered an error as soon as someone installed Backpack...

I just merged your PR and tagged it, it's available with a composer update.

Cheers and kudos to you for providing a PR! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants