Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified crud controller stub #43

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Conversation

tabacitu
Copy link
Member

  • Explicitly mention people shouldn't use setFromDb(), with standard TODO.
  • Remove commented API methods.

@todo
Copy link

todo bot commented Aug 19, 2018

remove setFromDb() and manually define Fields and Columns

// TODO: remove setFromDb() and manually define Fields and Columns
$this->crud->setFromDb();
// add asterisk for fields that are required in DummyClassRequest
$this->crud->setRequiredFields(StoreRequest::class, 'create');


This comment was generated by todo based on a TODO comment in 6b29994 in #43. cc @Laravel-Backpack.

@tabacitu
Copy link
Member Author

Up! Still think this is a good idea :-)

@tabacitu tabacitu merged commit 6b29994 into master Aug 27, 2018
@tabacitu tabacitu deleted the crud-controller-simplify branch August 27, 2018 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant