Added explanations to readme #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified wording in section on installation using composer
Modified list of composer commands based on version to a table
caouecs
reviewed
Jul 23, 2020
README.md
Outdated
|
|
||
| * in version 6.1, we propose a new file by language: `validation-inline.php` ( see #1268 ) | ||
| * in version 7, we propose new directory names to follow ISO-15897 ( see #1269 ) | ||
| * In Laravel version 6.1, we propose a new file by language: `validation-inline.php` ( see #1268 ) |
There was a problem hiding this comment.
No, it's the version 6.1 of this project, not Laravel :)
README.md
Outdated
| * in version 6.1, we propose a new file by language: `validation-inline.php` ( see #1268 ) | ||
| * in version 7, we propose new directory names to follow ISO-15897 ( see #1269 ) | ||
| * In Laravel version 6.1, we propose a new file by language: `validation-inline.php` ( see #1268 ) | ||
| * in Laravel version 7, we propose new directory names to follow ISO-15897 ( see #1269 ) |
There was a problem hiding this comment.
the same, the version 7 of this project
There was a problem hiding this comment.
Why would one be interested in installing an old version of this project?
There was a problem hiding this comment.
This project is used by other projects to install easier the files. And some updates, like directory names, can break this projects.
Then, some versions are depending on Laravel version.
There was a problem hiding this comment.
Okay, so I revert these changes.
|
Tak |
|
Je vous en prie (😄 ?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.