Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[de]: Fix translation into German #3608

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

Muetze42
Copy link
Contributor

No description provided.

@andrey-helldar andrey-helldar changed the title refactor: german language [de]: Fix translation into German Oct 24, 2023
@andrey-helldar
Copy link
Member

@sotten, @WhereIsLucas, can you check this PR?

@sotten
Copy link
Contributor

sotten commented Oct 29, 2023

I have already given a suggestion for improvement.

@andrey-helldar
Copy link
Member

I have already given a suggestion for improvement.

@sotten, I didn’t see any reactions or comments in this PR, and so I just decided to trigger it in case, when assigning a reviewer, emails are not sent due to personal notification settings 🙂

@andrey-helldar
Copy link
Member

@sotten, do I understand correctly that the existing translation in the project is ideal and the changes proposed in this PR are not needed?

@sotten
Copy link
Contributor

sotten commented Nov 1, 2023

@sotten, do I understand correctly that the existing translation in the project is ideal and the changes proposed in this PR are not needed?

"attached" should be "Der Anhang ist bereits vorhanden."
The other changes are an improvement.

@andrey-helldar
Copy link
Member

@sotten, do I understand correctly that the existing translation in the project is ideal and the changes proposed in this PR are not needed?

"attached" should be "Der Anhang ist bereits vorhanden." The other changes are an improvement.

@Muetze42, can you fix that?

@andrey-helldar
Copy link
Member

@sotten, perhaps you didn’t click on the “Finish your review” button, so there were no messages in the PR ¯_(ツ)_/¯

image

@@ -9,7 +9,7 @@
"alpha_num": "Der Inhalt darf nur aus Buchstaben und Zahlen bestehen.",
"array": "Dieses Feld muss ein Array sein.",
"ascii": "Dieses Feld darf nur alphanumerische Single-Byte-Zeichen und -Symbole enthalten.",
"attached": "Dieses Feld ist bereits angehängt.",
"attached": "Dieses Feld ist bereits angehangen.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Der Anhang ist bereits vorhanden."?

@@ -9,7 +9,7 @@
"alpha_num": "Der Inhalt darf nur aus Buchstaben und Zahlen bestehen.",
"array": "Dieses Feld muss ein Array sein.",
"ascii": "Dieses Feld darf nur alphanumerische Single-Byte-Zeichen und -Symbole enthalten.",
"attached": "Dieses Feld ist bereits angehängt.",
"attached": "Dieses Feld ist bereits angehangen.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Der Anhang ist bereits vorhanden."?

@andrey-helldar
Copy link
Member

@Muetze42, ping?

@Muetze42
Copy link
Contributor Author

"Der Anhang ist bereits vorhanden.". This sentence is based on the English original:
"attached": "This field is already attached.",

According to the English template, it is as I have changed it.

"Der Anhang ist bereits vorhanden."would be if it is a file attachment.

@andrey-helldar
Copy link
Member

@sotten, can you check this PR again?

@sotten
Copy link
Contributor

sotten commented Dec 7, 2023

"Dieses Feld ist bereits angehangen" doesn't sound correct. I will approve the PR though.

Copy link
Member

@andrey-helldar andrey-helldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke

@andrey-helldar andrey-helldar merged commit 291c448 into Laravel-Lang:main Dec 7, 2023
5 checks passed
@Muetze42
Copy link
Contributor Author

Muetze42 commented Dec 7, 2023

This field is already attached.

Es ist halt die Übersetzung von This field is already attached..
Ich weiß leider aber auch nicht wo dieser String verwendet wird. Vielleicht ist ja sogar der englische Text komplett. Denn selbst auf Englisch klingt es seltsam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants