Merge pull request #188 from skyrpex/patch-1

Treat boolean attributes as HTML properties
LaravelCollective · Dec 13, 2016 · 8956f00 · 8956f00
2 parents abec449 + dc15cf8
commit 8956f00
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/HtmlBuilder.php b/src/HtmlBuilder.php
@@ -447,6 +447,11 @@ protected function attributeElement($key, $value)
         if (is_numeric($key)) {
             $key = $value;
         }
+
+        // Treat boolean attributes as HTML properties
+        if (is_bool($value)) {
+            return $value ? $key : '';
+        }
 
         if (! is_null($value)) {
             return $key . '="' . e($value) . '"';

diff --git a/tests/HtmlBuilderTest.php b/tests/HtmlBuilderTest.php
@@ -58,7 +58,7 @@ public function testTag()
             $this->htmlBuilder->image('http://example.com/image1'),
             $this->htmlBuilder->image('http://example.com/image2'),
         ];
-        
+
         $result4 = $this->htmlBuilder->tag('div', $content, ['class' => 'row']);
 
         $this->assertEquals('<p>' . PHP_EOL . 'Lorem ipsum dolor sit amet.' . PHP_EOL . '</p>' . PHP_EOL, $result1);
@@ -115,4 +115,15 @@ public function testMailto()
         $this->assertEquals('<a href="mailto:person@example.com" class="example-link">&lt;span&gt;First Name Last&lt;/span&gt;</a>', $result1);
         $this->assertEquals('<a href="mailto:person@example.com" class="example-link"><span>First Name Last</span></a>', $result2);
     }
+
+    public function testBooleanAttributes()
+    {
+        $result1 = $this->htmlBuilder->attributes(['my-property' => true]);
+
+        $result2 = $this->htmlBuilder->attributes(['my-property' => false]);
+
+        $this->assertEquals('my-property', trim($result1));
+
+        $this->assertEquals('', trim($result2));
+    }
 }