Treat boolean attributes as HTML properties

[skyrpex]

HTML properties shouldn't have value. Attributes with boolean values will now be represented as HTML properties.

Given this Blade snippet:

{!! Form::text('timezone', null, ['class' => 'form-control', 'placeholder' => 'Timezone', 'my-property' => true]); !!}

It will compile to:

<input class="form-control" placeholder="Timezone" my-property name="timezone" type="text" id="timezone">

[mlantz]

Unit test please :)

[decadence]

@skyrpex why did you stop? Make unit tests please. I think your changes are useful for readonly or disabled attributes. I hope false value does not output attribute.

[decadence]

#208

[skyrpex]

This should do it.

[decadence]

Guys sorry about not relative question, but who is able to review PRs on this repo?
I don't see much activity here about it and I see some PRs without attention.
I would like anyone to consider my suggestion here: #217

[skyrpex]

Sigh...

[andrzejkupczyk]

This is good for custom attributes. If you care about W3C standards, check this PR instead.

[EspadaV8]

Copy/pasting from my comment in #252

@andrzejkupczyk When it mentions 'the empty string' that also allows it to be omitted. You can see examples of boolean attributes here W3C Boolean Attributes

Here is an example of a checkbox that is checked and disabled. The checked and disabled attributes are the boolean attributes.

<label><input type=checkbox checked name=cheese disabled> Cheese</label>

This could be equivalently written as this:

<label><input type=checkbox checked=checked name=cheese disabled=disabled> Cheese</label>

You can also mix styles; the following is still equivalent:

<label><input type='checkbox' checked name=cheese disabled=""> Cheese</label>

The information about omitting empty string values is mentioned in the secion A Quick Introduction to HTML about 4 paragraphs in (emphasis mine)

Attributes are placed inside the start tag, and consist of a name and a value, separated by an "=" character. The attribute value can remain unquoted if it doesn't contain space characters or any of " ' ` = < or >. Otherwise, it has to be quoted using either single or double quotes. The value, along with the "=" character, can be omitted altogether if the value is the empty string.

[skyrpex]

👍

On Tue, Oct 25, 2016, 12:07 AM Andrew Smith notifications@github.com
wrote:

Copy/pasting from my comment in #252
#252

@andrzejkupczyk https://github.com/andrzejkupczyk When it mentions 'the
empty string' that also allows it to be omitted. You can see examples of
boolean attributes here W3C Boolean Attributes
https://www.w3.org/TR/html5/single-page.html#boolean-attributes

Here is an example of a checkbox that is checked and disabled. The checked
and disabled attributes are the boolean attributes.

Cheese

This could be equivalently written as this:

Cheese

You can also mix styles; the following is still equivalent:

Cheese

The information about omitting empty string values is mentioned in the
secion A Quick Introduction to HTML
https://www.w3.org/TR/html5/single-page.html#intro-early-example about
4 paragraphs in (emphasis mine)

Attributes are placed inside the start tag, and consist of a name and a
value, separated by an "=" character. The attribute value can remain
unquoted if it doesn't contain space characters or any of " ' ` = < or >.
Otherwise, it has to be quoted using either single or double quotes. The
value, along with the "=" character, can be omitted altogether if the value
is the empty string.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#188 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABBxEPN2sNl-BKGjMHp2dE3_GPgeVS7Fks5q3SwXgaJpZM4IR2tM
.

[alexmglover]

It looks like this change is not available on 5.3. Is this intentional?