Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option in setup/settings to choose between mm/s and mm/min #55

Closed
cojarbi opened this issue Dec 8, 2016 · 5 comments
Closed

Option in setup/settings to choose between mm/s and mm/min #55

cojarbi opened this issue Dec 8, 2016 · 5 comments

Comments

@cojarbi
Copy link
Collaborator

cojarbi commented Dec 8, 2016

Its simple math but have the option to choose either make it more comfortable

@jorgerobles
Copy link
Collaborator

@cojarbi Setting is stored, now needs propagation.

@tbfleming
Copy link
Member

It's now in place, but has a bug. If the setting is empty, the CAM assumes mm/min since that's what gcode normally is. The settings UI shows mm/s when the setting's empty.

jorgerobles added a commit to jorgerobles/LaserWeb4 that referenced this issue Dec 11, 2016
@jorgerobles
Copy link
Collaborator

jorgerobles commented Dec 11, 2016 via email

@tbfleming
Copy link
Member

react-select gives you an object; you need to get just the value from it.

image

@jorgerobles
Copy link
Collaborator

jorgerobles commented Dec 11, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants