Add dataparser for handelsbanken / BEC banks #23
Conversation
|
Nice and thanks! Always good with PR's - I'll look at it later and merge it. |
|
@larsbaunwall Sorry, haven't merged yet, as I haven't had the time - busy at work - I will look at it soon how ever :) Again, thanks for you pull request. |
|
Hi @larsbaunwall However, could I ask you to add a Unittest for your new DataParser too? |
| } | ||
|
|
||
| [DelimitedRecord(";"), IgnoreEmptyLines(), IgnoreFirst()] | ||
| private class SparNordEntry |
There was a problem hiding this comment.
@larsbaunwall Guess you missed renaming 'SparNordEntry'? I know it's private and all, but the name is miss leading.
|
@larsbaunwall Hi Lars, did you have time to look at my comments? |
|
@larsbaunwall I'm not sure if you don't see these messages or you just don't have time to look into this. Can you please reply, if you get these and just haven't had time to look into it? I would very much like to have this PR merged in :) |
|
Hi Mads. |
…l in case someone manages to export without a trailing semicolon
|
Just committed the changes - hope you like them :) |
|
@larsbaunwall No problem, no rush - just wanted to make sure you got the notification, so at least that wasn't the reason why :) Very nice, I'll take a look at your changes soon - thanks for your pull request once again! |
|
@larsbaunwall Looked good! I see 2 unittests fails, but they do that in master too, so it's not your fault. I'll look at it in the master branch. Thank you so much for your Pull Request - keep 'em coming :) |
Add support for Handelsbanken / BEC export in the format [Date;Text;Amount;Saldo;Dummy]