New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataparser for handelsbanken / BEC banks #23

Merged
merged 3 commits into from Feb 5, 2018

Conversation

Projects
None yet
2 participants
@larsbaunwall
Contributor

larsbaunwall commented Dec 1, 2017

Add support for Handelsbanken / BEC export in the format [Date;Text;Amount;Saldo;Dummy]

@Laumania

This comment has been minimized.

Owner

Laumania commented Dec 1, 2017

Nice and thanks! Always good with PR's - I'll look at it later and merge it.

@Laumania

This comment has been minimized.

Owner

Laumania commented Dec 7, 2017

@larsbaunwall Sorry, haven't merged yet, as I haven't had the time - busy at work - I will look at it soon how ever :)

Again, thanks for you pull request.

@Laumania

This comment has been minimized.

Owner

Laumania commented Dec 8, 2017

Hi @larsbaunwall
Again, sorry for the delay. I looked at your changes and let me say first, nicely done - you keep indenting stuff as the rest of the project - the OCD approves :P

However, could I ask you to add a Unittest for your new DataParser too?

@Laumania

Never tried this "Review" thing before to be honest. Seems pretty smart :)

}
[DelimitedRecord(";"), IgnoreEmptyLines(), IgnoreFirst()]
private class SparNordEntry

This comment has been minimized.

@Laumania

Laumania Dec 8, 2017

Owner

@larsbaunwall Guess you missed renaming 'SparNordEntry'? I know it's private and all, but the name is miss leading.

@Laumania

This comment has been minimized.

Owner

Laumania commented Dec 19, 2017

@larsbaunwall Hi Lars, did you have time to look at my comments?
I really want to have a Unittest added with a sample of the BEC file format, to make sure it doesn't break the logic behind finding the right parser for the uploaded file.

@Laumania

This comment has been minimized.

Owner

Laumania commented Jan 11, 2018

@larsbaunwall I'm not sure if you don't see these messages or you just don't have time to look into this. Can you please reply, if you get these and just haven't had time to look into it?

I would very much like to have this PR merged in :)

@larsbaunwall

This comment has been minimized.

Contributor

larsbaunwall commented Jan 16, 2018

Hi Mads.
You just saw your messages - have been occupied elsewhere for the last month or so.
I will look into your comments as soon as possible 👍

@larsbaunwall

This comment has been minimized.

Contributor

larsbaunwall commented Jan 16, 2018

Just committed the changes - hope you like them :)

@Laumania

This comment has been minimized.

Owner

Laumania commented Jan 16, 2018

@larsbaunwall No problem, no rush - just wanted to make sure you got the notification, so at least that wasn't the reason why :)

Very nice, I'll take a look at your changes soon - thanks for your pull request once again!

@Laumania Laumania merged commit a0bad9f into Laumania:master Feb 5, 2018

@Laumania

This comment has been minimized.

Owner

Laumania commented Feb 5, 2018

@larsbaunwall Looked good! I see 2 unittests fails, but they do that in master too, so it's not your fault. I'll look at it in the master branch.

Thank you so much for your Pull Request - keep 'em coming :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment