-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 8.0 #581
Version 8.0 #581
Changes from 3 commits
d51ea07
175c24c
c98affd
c80c8d4
a37f83f
b1ec311
660fc78
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
v16.14.2 | ||
v18.12.1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,11 @@ module.exports = async ({ config }) => { | |
// Storysource-addon | ||
config.module.rules.push({ | ||
test: /\.story\.jsx?$/, | ||
loaders: [require.resolve('@storybook/source-loader')], | ||
use: [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needed to change the webpack configuration in order to accommodate webpack 5. |
||
{ | ||
loader: require.resolve('@storybook/source-loader') | ||
} | ||
], | ||
enforce: 'pre', | ||
}) | ||
// Sass | ||
|
@@ -39,5 +43,12 @@ module.exports = async ({ config }) => { | |
src: path.resolve(__dirname, '../src'), | ||
}, | ||
} | ||
// Required for Node ^18.12.1 to resolve an OpenSSL configuraiton deprecation. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo: |
||
// See: https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported/73465262#73465262 | ||
config.output = { | ||
...config.output, | ||
hashFunction: 'xxhash64', | ||
} | ||
|
||
return config | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# v8.0.0 Migration Guide | ||
chawes13 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
This version contains the following breaking changes: | ||
|
||
1. Upgraded Node version to 18.12.1 | ||
2. Removed `node-sass` in favor of `sass` | ||
3. Upgraded webpack and related loaders | ||
|
||
Further explanation of each item is detailed below. | ||
|
||
--- | ||
|
||
## 1. Upgraded Node version to 18.12.1 | ||
|
||
Typically, the Node version of an application can be updated without any breaking change. However, Node 18 requires an upgraded version of `glibc`. This has impact on both Travis and the existing `node-sass` executable. | ||
|
||
For Travis, the default distribution used for builds and test execution does not have the version of `glibc` required by Node 18. To resolve this issue, a specific distribution is specified in the `.travis.yml` configuration file that has the correct `glibc` version. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you reference the distribution name directly in this paragraph please? Any official docs from Travis to reference for more info? |
||
|
||
`node-sass` has been deprecated and the latest version does not support the later `glibc` version (an exception is generated when one tries to execute `node-sass` with the later Node version). To resolve this, `node-sass` was removed and `sass` (Dart Sass, the currently active Sass implementation) was added. This change required an additional update to the `build:styles` script to use `sass` for style builds. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add this paragraph to the section below. |
||
|
||
Finally, this version of `lp-components` will not support older Node versions. You must use Node version ^18.12.1. | ||
|
||
## 2. Removed `node-sass` in favor of `sass` | ||
|
||
As mentioned above, `node-sass` was removed in favor of `sass`. Additionally, the latest version of `style-loader` was included in this version of `lp-components`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's fine. Removed. |
||
|
||
## 3. Upgraded webpack and related loaders | ||
|
||
The Node upgrade [mentioned above](#1-upgraded-node-version-to-18121) also fixed an OpenSSL issue. That fix required that the latest version of Webpack be used, along with configuration of a specific hashing function. To accommodate this change, webpack was upgraded to ^5.75.0 and the `css-loader`, `style-loader`, and `sass-loader` were also upgraded to their latest versions. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to upgrade to webpack 5 in order to resolve issues with Node 18 and SSL. See: https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported