Updated gradient_descent example #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran into some problems in running the `gradient_descent` example, these changes made it possible to run the example for us. (Worked with @chrisalgerges98)
README.md
Outdated
| use tch::nn; | ||
| use tch::Tensor; | ||
| use tch::nn::*; | ||
| use tch::*; |
There was a problem hiding this comment.
Maybe we could avoid the wildcard uses as they bring lots of things in the scope and instead a use tch::kind would be enough?
|
Leaving out all wildcards would give the following imports. use tch::kind;
use tch::nn;
use tch::nn::Module; // for the `forward` method
use tch::nn::OptimizerConfig; // for the `build` method
use tch::Device;
use tch::Tensor;If you feel this is a better way to do it I will change my PR. |
|
I would slightly lean towards something like this indeed. Note that you can make things a bit more compact if you prefer, e.g.: use tch::{kind,nn,Device,Tensor};
use tch::nn::{Module,OptimizerConfig}; |
|
Great, it is pushed to this PR. Thanks for the reminder of the compact form of the imports. |
LaurentMazare
approved these changes
May 13, 2021
|
Merged, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into some problems in running the
gradient_descentexample, these changes made it possible to run the example for us.(Worked with @chrisalgerges98)