[Feature] Add the option to restore vanilla portal view. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [MockBukkit-v1.16](https://github.com/MockBukkit/MockBukkit) from 1.5.0 to 1.5.2. - [Release notes](https://github.com/MockBukkit/MockBukkit/releases) - [Commits](https://github.com/MockBukkit/MockBukkit/commits) --- updated-dependencies: - dependency-name: com.github.seeseemelk:MockBukkit-v1.16 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps com.github.johnrengelman.shadow from 7.0.0 to 7.1.0. --- updated-dependencies: - dependency-name: com.github.johnrengelman.shadow dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps com.github.johnrengelman.shadow from 7.0.0 to 7.1.0. --- updated-dependencies: - dependency-name: com.github.johnrengelman.shadow dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [junit-vintage-engine](https://github.com/junit-team/junit5) from 5.7.2 to 5.8.1. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.7.2...r5.8.1) --- updated-dependencies: - dependency-name: org.junit.vintage:junit-vintage-engine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…hub.johnrengelman.shadow-7.1.0 Bump com.github.johnrengelman.shadow from 7.0.0 to 7.1.0
…om.github.johnrengelman.shadow-7.1.0 Bump com.github.johnrengelman.shadow from 7.0.0 to 7.1.0 in /final
Bumps [lombok](https://github.com/projectlombok/lombok) from 1.18.20 to 1.18.22. - [Release notes](https://github.com/projectlombok/lombok/releases) - [Changelog](https://github.com/projectlombok/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.20...v1.18.22) --- updated-dependencies: - dependency-name: org.projectlombok:lombok dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…com.github.seeseemelk-MockBukkit-v1.16-1.5.2 Bump MockBukkit-v1.16 from 1.5.0 to 1.5.2 in /bukkit
…jectlombok-lombok-1.18.22 Bump lombok from 1.18.20 to 1.18.22
…it.vintage-junit-vintage-engine-5.8.1 Bump junit-vintage-engine from 5.7.2 to 5.8.1
Bumps [junit-jupiter-api](https://github.com/junit-team/junit5) from 5.3.1 to 5.8.1. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.3.1...r5.8.1) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…it.jupiter-junit-jupiter-api-5.8.1 Bump junit-jupiter-api from 5.3.1 to 5.8.1
…UniqueId() + .yml
…er side of the portal.
|
Please also note that I updated all the dependencies Dependabot proposed, and changed the version in build.gradle, plugin.yml, and bungee.yml to 0.10.0 (from 0.9.0). |
Lauriethefish
requested changes
Oct 11, 2021
There was a problem hiding this comment.
Returning null if an error is found doesn't seem like ideal behavior here, as we'll get NPEs later.
It'd be better to try {} catch{} the loading/saving parts of loadPermanentDataYml, and returning the default configuration if loading fails for example.
Of course, the error should still be logged as to explain why the player's options haven't been saved.
|
Oops, looked like I made a mistake with reviewing. To clarify, the problems here are in |
… when there is an IO error.
|
Should be fixed now. I agree, probably not the best thing to have put a return null there. |
Lauriethefish
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first proposed a PR on this in #63, added the feature requested in #37 and #50. Back then, I was not as advanced and did not understand some parts of the code. It was really garbage looking back. After more experience, I hope this code is good enough. Please note that all checks will fail on my side, as I cannot publish Jar to webhook (required to pass Java CI).
I created a player data file for each player, located at "plugins/BetterPortals/playerData/" + player#getUniqueId() + ".yml". The data file holds one piece of data by default, which is "seeThroughPortal: true". A command called "/bp setSeeThroughPortal" has also been added so that players can toggle this setting in game. The command edits the value in their data file. The command requires the permission "betterportals.see" to be used (not that a player can view a portal without this permission anyway), and will send a success message on use.
To stop players from viewing a portal when they indicate that they want vanilla behaviour, I added a new class that implements PortalPredicate, which checks for their preference.
I hope that this PR will finally get Github to think that I did more than Dependabot!