Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: remove self, fix register datatype for PelletsBoiler #22

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Bugfix: remove self, fix register datatype for PelletsBoiler #22

merged 4 commits into from
Feb 22, 2023

Conversation

lein1013
Copy link
Contributor

@lein1013
Copy link
Contributor Author

hold on ! - need to do some more bugfix

@lein1013
Copy link
Contributor Author

Tested now with the example.py

pellet_usage_last_fill| raw:0 scaled:0.0
pellet_usage_total| raw:8819 scaled:881.9000000000001
heat_energy_total| raw:40615 scaled:4061.5

@LavermanJJ should work now, please release

@lein1013 lein1013 changed the title Bugfix: remove self in PelletsBoiler Bugfix: remove self, fix register datatype for PelletsBoiler Feb 4, 2023
LavermanJJ
LavermanJJ approved these changes Feb 22, 2023
View reviewed changes
Copy link
Owner

@LavermanJJ LavermanJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the fix and sorry for the delay. I'll revert the example.py file back to heat-pump but leave the pellets boiler commented out in it.

@LavermanJJ LavermanJJ merged commit bef1011 into LavermanJJ:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LavermanJJ LavermanJJ LavermanJJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lein1013 @LavermanJJ