Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Fix initial event (broken didChangeLocale/Theme) #48

Closed
x1B opened this issue Mar 3, 2017 · 2 comments
Closed

Fix initial event (broken didChangeLocale/Theme) #48

x1B opened this issue Mar 3, 2017 · 2 comments
Assignees
@x1B
Labels
breaking epic: developer tools
Milestone
v2.0.0

Comments

@x1B
Copy link
Member

x1B commented Mar 3, 2017 •
edited
Loading

Probably due to some copy/paste error, didChangeLocale is published twice initially, the second time with a theme payload. Should be didChangeTheme.
@x1B x1B added this to the v2.0.0 milestone Mar 3, 2017
@x1B x1B self-assigned this Mar 3, 2017
@x1B x1B changed the title Fix Fix initial event (didChangeLocale -> didChangeTheme) Mar 3, 2017
x1B added a commit that referenced this issue Mar 3, 2017
@x1B
(#48) event bus error details are now forwarded to the console
c17a3d2
@x1B
Copy link
Member Author

x1B commented Mar 3, 2017

Revisiting: we already dropped didChangeTheme from the runtime, so let's just get rid of it.

@x1B x1B changed the title Fix initial event (didChangeLocale -> didChangeTheme) Fix initial event (broken didChangeLocale/Theme) Mar 3, 2017
@x1B x1B added breaking and removed type: bug labels Mar 3, 2017
x1B added a commit that referenced this issue Mar 3, 2017
@x1B
(#48) removed initial didChangeTheme event
333c459
@x1B
Copy link
Member Author

x1B commented Mar 3, 2017

Implemented on master (v2.0.0).

BREAKING CHANGE

In accordance with LaxarJS core, no didChangeTheme event is published anymore when using triggerStartupEvents.

@x1B x1B closed this as completed Mar 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@x1B x1B

Labels
breaking epic: developer tools
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@x1B @mkemmann