Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

flow: (v2.x) place with parameter, but without constant prefix, does not match empty path #388

Closed
x1B opened this issue Nov 7, 2016 · 2 comments
Assignees
Milestone

Comments

@x1B
Copy link
Member

x1B commented Nov 7, 2016

There is a specific use-case that does not seem to be handled correctly by the flow controller: when a place name consists of just a place parameter (e.g. :some-param) it will match any URL that consists of a single path segment (good), but it will match neither empty URLs nor URLs consisting of just a slash.

This behavior is inconsistent with place definitions that do have a constant prefix. These do match URLs with an empty trailing parameter segment.

@x1B x1B added this to the v2.0.0 milestone Nov 7, 2016
@x1B x1B changed the title flow: (v2.x) place with parameter, but without constant prefix does not match empty path flow: (v2.x) place with parameter, but without constant prefix, does not match empty path Nov 7, 2016
@x1B
Copy link
Member Author

x1B commented Nov 8, 2016

Ok, the reason is that some of the regular expressions used in route parameter matching are too specific, demanding a slash before each parameter's colon.

@x1B
Copy link
Member Author

x1B commented Nov 8, 2016

Fixed on master (v2.0.0).

@x1B x1B closed this as completed Nov 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant