This repository has been archived by the owner on May 22, 2023. It is now read-only.
Move LaxarJS branding to theme #7
Labels
Comments
x1B
added a commit
that referenced
this issue
Nov 11, 2014
x1B
added a commit
that referenced
this issue
Nov 11, 2014
x1B
added a commit
that referenced
this issue
Nov 11, 2014
x1B
added a commit
that referenced
this issue
Nov 11, 2014
x1B
added a commit
that referenced
this issue
Nov 11, 2014
x1B
added a commit
that referenced
this issue
Nov 11, 2014
* feature/7-move-branding-to-theme-rebase: (#7) Extracted most styles into laxar_demo.theme
|
Merged into |
x1B
added a commit
to x1B/shop-demo
that referenced
this issue
Nov 12, 2014
* release-1.3.x: release v1.3.0 Changed shop_demo theme to laxar_demo Updated grunt-laxar dependency to v0.5.2 (LaxarJS/grunt-laxar/issues/24) (LaxarJS#10) darkly_scss: Fixed selector precedence, changelog (LaxarJS#10) Added SCSS based version of darkly theme. Updated grunt-laxar dependency, and enabled various optimizations. (LaxarJS#9) documentation: Fixed links in README.md (LaxarJS#8) theming: added darkly theme (LaxarJS#7) Extracted most styles into laxar_demo.theme Updated links to laxar documents Updated links to laxar documents ArticleBrowserWidget Tutorial: fixed example (LaxarJS#4) Changelog (LaxarJS#4) Removed duplicate data-ax-widget-area Hello World Tutorial: Fixed source code example Added forgotten files (LaxarJS#3) Changelog (LaxarJS#3) Styling: Added support for retina images (LaxarJS#2) Changelog (LaxarJS#2) Styling: Fixed add button is not usable for small viewports. Some further improvements. Conflicts: CHANGELOG.md application/layouts/application/default.theme/application.html application/layouts/application/default.theme/css/application.css application/layouts/application/laxar_demo.theme/scss/_base.scss bower.json includes/widgets/shop_demo/shopping_cart_widget/default.theme/css/shopping_cart_widget.css
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, the LaxarJS widgets and the application are styled directly in the context of the
default.theme.This makes it difficult to add a custom theme, because that would have to add styling for the application and all widgets to overwrite the LaxarJS style, and then to implement the functional styles again (centering etc.).
Instead, we should create a laxar.theme for the shop demo, and move all non-essential styling there. This would also simplify the tutorials (for themeing, they could simply refer to the main manual, because that uses the shop demo anyway).
The text was updated successfully, but these errors were encountered: