-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third Level Domains, Additional TLDs, & Bug Fixes #80
Conversation
|
Check if TLD has a whois server in the IANA database. If not, fetch it from other sources.
hey @popeeyy thanks for this contribution. I will test it a bit more in the following days, then it will be merged and released. Thanks |
There is one issue that I have not addressed and that is third level TLD WHOIS servers are not appropriately cached yet. I'm not sure what the best way to implement that would be since I don't want to accidentally query a domain as a third level domain when it's actually a normal TLD. I'm not sure if it's even needed as DNS queries are used to get the WHOIS servers for third level domains rather than a WHOIS query. |
@popeeyy this is merged and included in the v1.14 release, and I'm testing it now on https://dmns.app After testing it on a few third level domains, I think the
and the |
@AndreiIgna IANA was not returning the correct WHOIS servers at least for third level domains ending in Example: roblox.ru.com |
great, I'll add this example to the tests file, then see what works best as default options |
@AndreiIgna I would make sure to add a different domain on a similar TLD as the one I listed will be thrown back into the registry soon since it was a phishing domain. |
@popeeyy after 1 week of testing on https://dmns.app/tlds & domains whois, I saw that the I'm making some changes in #86 to find some good defaults on when to use this function, and if you have more tlds or domains to test it against, please add them here |
Adds more queries to get whois servers with DNS if they don't exist in the IANA database. (third level domains and other obscure TLDs) Also adds support for looking up third level domains such as .co.uk. I did use optional chaining if that is an issue for supporting older node.js versions.
Also fixes .gg, .je, and .as whois results as they use new lines and have a weird registrar field. Closes #50
Now follows referral server for the RIPE database. Closes #72