Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more sources for TLD whois #86

Merged
merged 3 commits into from
Feb 4, 2023
Merged

Use more sources for TLD whois #86

merged 3 commits into from
Feb 4, 2023

Conversation

AndreiIgna
Copy link
Member

Q A
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Use whoisTldAlternate for TLD whois only when whois is not found in IANA request.
Current implementation creates 2 problems that need fixing:

  • whoisTldAlternate is used by default for third-level domains, and it bypasses IANA request, which is valid in many cases and includes much more tld info (contacts, organization, created date, updated date, and more)
  • when a tld is found in Iana request with whois field is empty, whoisTldAlternate overwrites all tld info (contacts, dates, etc). Ex tlds: analytics, dupont, music

@height
Copy link

height bot commented Jan 21, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@AndreiIgna AndreiIgna merged commit f8b25cb into master Feb 4, 2023
@AndreiIgna AndreiIgna deleted the whois-alternate branch February 4, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant