increase churner expiry #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 13, 2024 19:22
bxue-l2
requested review from
jianoaix,
gpsanant and
mooselumph
and removed request for
jianoaix
gpsanant
approved these changes
Apr 13, 2024
ian-shim
approved these changes
Apr 14, 2024
operators/churner/server_test.go
Outdated
| @@ -92,7 +92,7 @@ func TestChurn(t *testing.T) { | |||
| // retry prior to expiry should fail | |||
| _, err = s.Churn(ctx, request) | |||
| assert.NotNil(t, err) | |||
| assert.Equal(t, err.Error(), "rpc error: code = ResourceExhausted desc = previous approval not expired, retry in 90") | |||
| assert.Equal(t, err.Error(), "rpc error: code = ResourceExhausted desc = previous approval not expired, retry in 3600") | |||
There was a problem hiding this comment.
nit: retry in 3600s or retry in 1 hour
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks