Backward compatibility with using entire g2 #482
Conversation
| @@ -70,21 +70,24 @@ func NewVerifier(config *kzg.KzgConfig, loadG2Points bool) (*Verifier, error) { | |||
| return nil, err | |||
| } | |||
| } else { | |||
| if len(config.G2PowerOf2Path) == 0 { | |||
| return nil, errors.New("G2PowerOf2Path is empty. However, object needs to load G2Points") | |||
| if len(config.G2PowerOf2Path) == 0 && len(config.G2Path) == 0 { | |||
There was a problem hiding this comment.
The config.G2Path isn't used below, although it's checking it here.
What if the control flow is if loadG2Points || len(config.G2PowerOf2Path) == 0 { ... } above? This entire block won't need to change
There was a problem hiding this comment.
It is used to ensure backward compatibility for operators who uses the entire G2 points, though very unlikely. In the last PR #472 , node is required to read the powerOf2 file at start. However, it prevents the legacy usecase when the node is accessing the entire points.
There was a problem hiding this comment.
node sets loadG2Points to be false.
There was a problem hiding this comment.
I think my suggestion has the same logic, but simpler code?
| @@ -21,7 +21,7 @@ import ( | |||
|
|
|||
| var ( | |||
| bipMultiplier = big.NewInt(10000) | |||
| secondsTillExpiry = 90 * time.Second | |||
| secondsTillExpiry = 3600 * time.Second | |||
There was a problem hiding this comment.
90sec is too stringent for some operators to opt in, especially smart contract operator. though it is already merged from #481
Why are these changes needed?
This is a correction for PR #472 which checks g2powerof2 file before starting node. However, #472 prevents a legacy usage that the operator might only have the entire g2 file.
Checks