Cleaning prisma query engine after tests #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… jest subprocesses and correctly cleaning prisma engine
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Jest launches one subprocess per test suites
To this is added one other subprocess, the globalSetup
Each of those subprocesses does not correctly clear Prisma query engine, so they stay as orphan processes
Solution
This PR move the setup logic into the beforeAll hook of Jest, located directly inside test suites, so the globalSetup is not anymore needed
Since the database is instanciated from inside test suites, it enables calling prisma.$disconnect in the afterAll hook of Jest