Fix cursor grabbing #318
Merged
Fix cursor grabbing #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On wayland the cursor wouldn't be grabbed properly due to a winit/wayland compositor bug see rust-windowing/winit#3566 this was fixed by not setting the grab mode every frame but just setting it once a change in game state occurred. Furthermore we now prefer the Locked grab mode when available as that's a better representation of what we are actually trying to do.
Fixes: #316 #265 (although already fixed through a quick and dirty fix by @cooltexture1)