[BUILD] Use make's linker flags for libraries #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itislu
force-pushed
the
build-linker-flags
branch
4 times, most recently
from
3b4bba7
to
f6b9ff3
Compare
itislu
force-pushed
the
build-linker-flags
branch
from
f6b9ff3
to
0f3f74b
Compare
LeaYeh
force-pushed
the
build-linker-flags
branch
from
0f3f74b
to
721d00e
Compare
LeaYeh
approved these changes
Aug 15, 2024
itislu
force-pushed
the
build-linker-flags
branch
from
721d00e
to
3d964a2
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also finally understand why the order of the linker flags matters!
First the flags, then the source files which need the libraries, then the libraries.
This is because the linker looks for the symbols missing in a given file only in the files coming after it.
The location of where to look for the libraries (
-L/LDFLAGS) is a flag for the linker, so it should be in front.And the actual libraries to include (
-l/LDLIBS) need to be after the object files.That's why it makes sense that
LDFLAGSandLDLIBSare separate variables.