Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Rectangle support to npm #71

Closed
w8r opened this issue Apr 20, 2016 · 8 comments
Closed

Publish Rectangle support to npm #71

w8r opened this issue Apr 20, 2016 · 8 comments

Comments

@w8r
Copy link

w8r commented Apr 20, 2016

Currently, only the gh-pages branch and no npm release have Rectangle editing support. Could you please publish a beta package to npm or let us know what is missing for that to happen, maybe someone can help?

@yohanboniface
Copy link
Member

I'll do that very soon. I was expecting the release of Leaflet 1.0.0-rc1 to do so.

@w8r
Copy link
Author

w8r commented Apr 20, 2016

But leaflet@1.0.0-rc1 is already out, you can also make an RC release. It's just that the product I am currently developing has fallen into the dependency hell because I have to install your component from github, and then it duplicates Leaflet dependency and so on and on.

I am now trying to use your component with two extensions we've came up with, for dragging and for text fields.

@yohanboniface
Copy link
Member

But leaflet@1.0.0-rc1 is already out,

I sort of now that…

It's just that the product I am currently developing has fallen into the dependency hell because

You can still point to github directly

@w8r
Copy link
Author

w8r commented Apr 20, 2016

You can still point to github directly

that's what I'm doing, that causes problems with at least 2 versions of npm, it installs several instances of leaflet as dependencies then

@yohanboniface
Copy link
Member

I'm working on this during the week-end.
For now I removed Leaflet from the dependencies, so you don't fall into npm hell.
I need to check some issues and then I'll publish a proper rc release.

@w8r
Copy link
Author

w8r commented Apr 23, 2016

Thank you so much for doing so and your understanding

On 23 апр. 2016 г., at 10:06, Yohan Boniface notifications@github.com wrote:

I'm working on this during the week-end.
For now I removed Leaflet from the dependencies, so you don't fall into npm hell.
I need to check some issues and then I'll publish a proper rc release.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@yohanboniface
Copy link
Member

Pushed 1.0.0-rc.1 on npm.

@yohanboniface
Copy link
Member

BTW, nice work on Leaflet.Editable.Drag :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants