Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup should not go offscreen on resize #1052

Closed
lapo-luchini opened this issue Oct 9, 2012 · 1 comment
Closed

Popup should not go offscreen on resize #1052

lapo-luchini opened this issue Oct 9, 2012 · 1 comment
Assignees
Labels
Milestone

Comments

@lapo-luchini
Copy link

When screen is resized (it happens often to me because I have a popup with a text field and android opening the keyboard resizes the full-screen-map) the center of the map is used as pivot, but if there is a popup on screen it would be nice to keep the popup visible (just like the popup does when it opens up in the first time).

I tried doing that with commit lapo-luchini/Leaflet@6940786 but that doesn't really work if the popup doesn't fit on screen (his own panBy generates a new moveend and it keeps bouncing left and right if wider than the screen). Proper fix would probably need firing viewreset after a resize, but I didn't find a nice way to do that (should be done on animation end, but that's managed elsewhere and it's not easy to modify).

@mourner
Copy link
Member

mourner commented Apr 21, 2013

Done. #1308

@mourner mourner closed this as completed Apr 21, 2013
@ghost ghost assigned mourner Apr 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants