-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of leaflet.ie.css #2159
Comments
+1, will /cc in css master @tristen |
Very happy to drop IE6 support (I never test on it myself etc etc). I'm not a huge fan of the _*\9 css hacks, they are just really ugly and hacky! We could go for something like this: But really the _*\9 css hacks are probably ok. |
The only reason that has kept me from dropping IE6 is that minimally supporting it doesn't require any effort atm, and there's not much legacy code to remove (a couple lines of CSS, png fix for marker icons and that's it probably). |
I like the idea of putting the hacks under a |
Cleaned up and improved old IE stylesheets and moved them into the main CSS file (namespaced with |
Also dropped IE6-specific hacks. Leaflet isn't super-great on IE6 already so a couple less hacks won't make it much worse. And nobody cares. |
Removed since Leaflet v0.7 (present in v0.6.2) Leaflet/Leaflet#2159
Leaflet removed leaflet.ie.css in Leaflet/Leaflet#2159
As old IE versions get used less and less with time, and it's also time to drop at least IE6 support already, we can simplify some of the fallback rules in the current IE-only CSS (
leaflet.ie.css
), and move them to the mainleaflet.css
file (perhaps with the help of some hacks).Once the IE-only CSS is small enough, there's not much point in keeping it in a separate file, and it also makes the Leaflet include code snipped much simpler by ditching the conditional comment.
I know IE targeting CSS hacks are considered a bad practice, but in this case, I think it's justified.
cc @tmcw @danzel
The text was updated successfully, but these errors were encountered: