Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of leaflet.ie.css #2159

Closed
mourner opened this issue Nov 6, 2013 · 6 comments
Closed

Get rid of leaflet.ie.css #2159

mourner opened this issue Nov 6, 2013 · 6 comments
Assignees
Milestone

Comments

@mourner
Copy link
Member

mourner commented Nov 6, 2013

As old IE versions get used less and less with time, and it's also time to drop at least IE6 support already, we can simplify some of the fallback rules in the current IE-only CSS (leaflet.ie.css), and move them to the main leaflet.css file (perhaps with the help of some hacks).

Once the IE-only CSS is small enough, there's not much point in keeping it in a separate file, and it also makes the Leaflet include code snipped much simpler by ditching the conditional comment.

I know IE targeting CSS hacks are considered a bad practice, but in this case, I think it's justified.

cc @tmcw @danzel

@ghost ghost assigned mourner Nov 6, 2013
@tmcw
Copy link
Contributor

tmcw commented Nov 6, 2013

+1, will /cc in css master @tristen

@danzel
Copy link
Member

danzel commented Nov 6, 2013

Very happy to drop IE6 support (I never test on it myself etc etc).
Definitely need to keep 7+ for the time being.

I'm not a huge fan of the _*\9 css hacks, they are just really ugly and hacky!

We could go for something like this:
http://www.paulirish.com/2008/conditional-stylesheets-vs-css-hacks-answer-neither/
and setting the class on the map element via js rather than via conditional comments (we already version detect oldie)
Which allows us to keep the css for old IE slightly separate, would take a bit more code though.

But really the _*\9 css hacks are probably ok.

@mourner
Copy link
Member Author

mourner commented Nov 6, 2013

The only reason that has kept me from dropping IE6 is that minimally supporting it doesn't require any effort atm, and there's not much legacy code to remove (a couple lines of CSS, png fix for marker icons and that's it probably).

@mourner
Copy link
Member Author

mourner commented Nov 6, 2013

I like the idea of putting the hacks under a .leaflet-oldie namespace. Much cleaner than the symbol hacks and I don't see any reasons not to do it.

@mourner mourner closed this as completed in 45181ce Nov 8, 2013
@mourner
Copy link
Member Author

mourner commented Nov 8, 2013

Cleaned up and improved old IE stylesheets and moved them into the main CSS file (namespaced with .leaflet-oldie). Looks good?

@mourner
Copy link
Member Author

mourner commented Nov 8, 2013

Also dropped IE6-specific hacks. Leaflet isn't super-great on IE6 already so a couple less hacks won't make it much worse. And nobody cares.

Lekensteyn added a commit to Lekensteyn/Leaflet.MarkerFollower that referenced this issue Dec 17, 2013
Removed since Leaflet v0.7 (present in v0.6.2)
Leaflet/Leaflet#2159
mineo added a commit to mineo/mb-places-map that referenced this issue Feb 20, 2014
Leaflet removed leaflet.ie.css in
Leaflet/Leaflet#2159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants