Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android click filtering causes clicks to be missed #2303

Closed
sowelie opened this issue Dec 16, 2013 · 7 comments
Closed

Android click filtering causes clicks to be missed #2303

sowelie opened this issue Dec 16, 2013 · 7 comments

Comments

@sowelie
Copy link

sowelie commented Dec 16, 2013

The code which filters Android clicks, to try and combat the Android "double click firing" bug, is too aggressive. It is causing clicks to be missed when a user taps from one marker to another. Users have to wait at least a second before tapping in order to avoid having their click "eaten" by the filtering code.

@mourner
Copy link
Member

mourner commented Dec 16, 2013

How about 400ms, will that work? Or maybe 500ms? I hate to use such ugly hacks in Android but we didn't find another way :( cc @danzel

@sowelie
Copy link
Author

sowelie commented Dec 16, 2013

Yeah I was thinking about that. My initial thought was use "setTimeout" but the problem is you don't know whether to cancel the original click event until you fire the handler...

In my testing, setting the upper threshold to 500ms seems to work much better. I am going to keep it in the back of my mind today and see if I can think of a better solution.

@danzel
Copy link
Member

danzel commented Dec 16, 2013

With the doubleclick bug, is the position of the tap the same? Maybe we could only filter them out in that case?
I don't have a device that reproduces it IIRC.

@mourner
Copy link
Member

mourner commented Dec 18, 2013

@sowelie any updates?

@sowelie
Copy link
Author

sowelie commented Dec 19, 2013

Nah, the user who was having the problem ended up going with 500ms and seemed to be happy with that. Honestly, I have been too busy in the past few days to do any real messing about with ideas.

@ri0ter
Copy link

ri0ter commented Apr 4, 2014

Correct my If I'm wrong, but does this bug only occurs on the stock android browser, right? Could we change the statement only for this browser? I've noticed that Chrome (version 33.0.1750, Android 4.0.4) behaves perfectly fine without this workaround.

@danzel
Copy link
Member

danzel commented Apr 7, 2014

If that's the case then send a PR to change it @ri0ter :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants