-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android click filtering causes clicks to be missed #2303
Comments
How about 400ms, will that work? Or maybe 500ms? I hate to use such ugly hacks in Android but we didn't find another way :( cc @danzel |
Yeah I was thinking about that. My initial thought was use "setTimeout" but the problem is you don't know whether to cancel the original click event until you fire the handler... In my testing, setting the upper threshold to 500ms seems to work much better. I am going to keep it in the back of my mind today and see if I can think of a better solution. |
With the doubleclick bug, is the position of the tap the same? Maybe we could only filter them out in that case? |
@sowelie any updates? |
Nah, the user who was having the problem ended up going with 500ms and seemed to be happy with that. Honestly, I have been too busy in the past few days to do any real messing about with ideas. |
Correct my If I'm wrong, but does this bug only occurs on the stock android browser, right? Could we change the statement only for this browser? I've noticed that Chrome (version 33.0.1750, Android 4.0.4) behaves perfectly fine without this workaround. |
If that's the case then send a PR to change it @ri0ter :) |
The code which filters Android clicks, to try and combat the Android "double click firing" bug, is too aggressive. It is causing clicks to be missed when a user taps from one marker to another. Users have to wait at least a second before tapping in order to avoid having their click "eaten" by the filtering code.
The text was updated successfully, but these errors were encountered: