Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement test for 'project' method of Map #8373

Open
Tracked by #8145
jonkoops opened this issue Aug 1, 2022 · 8 comments 路 May be fixed by #8636 or #9303
Open
Tracked by #8145

Implement test for 'project' method of Map #8373

jonkoops opened this issue Aug 1, 2022 · 8 comments 路 May be fixed by #8636 or #9303

Comments

@jonkoops
Copy link
Collaborator

jonkoops commented Aug 1, 2022

No description provided.

@jonkoops jonkoops mentioned this issue Aug 1, 2022
33 tasks
@jonkoops jonkoops changed the title project Implement test for 'project' method of Map Aug 1, 2022
@jonkoops jonkoops added good first issue Good for newcomers tests labels Aug 1, 2022
@shivamchourasia4
Copy link

I would like to work on this too. Can you please assign this to me?

@Satyabrat-Ojha
Copy link

I would also like to contribute, can you please assign it to me?

@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 8, 2022

I'm sorry, but someone already claimed this issue.

@alfawal
Copy link

alfawal commented Oct 20, 2022

I was trying to port some of the tests from ProjectionSpec, I am not sure if I did get the idea right.

The test case:

it("projects the southwest corner of the world", () => {
	console.log(2, map.project(L.latLng(-85.0511287798, -180)))
	expect(map.project(L.latLng(-85.0511287798, -180))).near([5.6, 0]);
});

The output:

LOG: 2, Object{x: 5.551115123125783e-17, y: 0.9999999999997871}
Chrome Headless 106.0.5249.119 (Windows 10): Executed 1027 of 1089 (1 FAILED) (skipped 11) (0 secs / 8.856 secs)
LOG: 'expected: Point(5.6, 0)'
Chrome Headless 106.0.5249.119 (Windows 10): Executed 1027 of 1089 (1 FAILED) (skipped 11) (0 secs / 8.856 secs)
Chrome Headless 106.0.5249.119 (Windows 10) Map #project projects the southwest corner of the world FAILED
        Error: expected 5.551115123125783e-17 to be within 4.6..6.6
            at Assertion.assert (node_modules/expect.js/index.js:96:13)
            at Assertion.within (node_modules/expect.js/index.js:248:10)
            at Function.within (node_modules/expect.js/index.js:499:17)
            at expect.Assertion.near (spec/suites/SpecHelper.js:6:7)
            at Context.<anonymous> (spec/suites/map/MapSpec.js:2427:56)

@jotang1 jotang1 linked a pull request Nov 5, 2022 that will close this issue
@sumit851
Copy link

i am interested in this issue .can i contribute to this issue i have basic knowledge on html css jquery bootstrap java also.

@dhiraj0911
Copy link

@Satyabrat-Ojha if you are not working on it please assign to me

@AshwinNema
Copy link

Hi,
I am new to open source. Can I take up this issue?

@Falke-Design
Copy link
Member

Hi @AshwinNema if you want, you can work on this. Please take a look into our comments of #8636

@AshwinNema AshwinNema linked a pull request Mar 26, 2024 that will close this issue
AshwinNema added a commit to AshwinNema/Leaflet that referenced this issue Mar 27, 2024
1. typo fix : changing corridinates to coordinates

2.changing to.be.equal to to.be.approximately for round off approximation
@ghost ghost mentioned this issue Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants