add test for project method #9303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanSanchez
requested changes
Mar 26, 2024
spec/suites/map/MapSpec.js
Outdated
| expect(a.y).to.be.equal(3101.3204602149353); | ||
| }); | ||
|
|
||
| it('test the other corridinates', () => { |
There was a problem hiding this comment.
typo: corridinates should be coordinates
spec/suites/map/MapSpec.js
Outdated
| const x = latLng([40, 83]); | ||
| const b = map.project(x, 5); | ||
| expect(b.x).to.be.equal(5984.711111111111); | ||
| expect(b.y).to.be.equal(3101.3204602149353); |
There was a problem hiding this comment.
Floating point number literals with lots of decimals are scary in tests, since they can hit rounding errors.
Instead of equal, use https://www.chaijs.com/api/assert/#method_approximately with a delta of... 1/1000000, maybe?
1. typo fix : changing corridinates to coordinates 2.changing to.be.equal to to.be.approximately for round off approximation
|
@Falke-Design I have made requested changes. Please let me know if anything else has to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8373.
@Falke-Design I am new to contribute to open source and let me know if anything needs to be changed.