FlyTo with targetCenter == currentCenter not animated #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see http://jsfiddle.net/v1so6m56/4/ If targetCenter is the same of currenteCenter the parameter u1 (the distance between "to" and "from" is 0. The proposed patch resolve this by forcing the distance to 1.
|
Thanks for the PR! The proposed change looks like a hack though, I wonder if I can find a more elegant solution... |
|
After fiddling with this for quite a while, I don't think it's easy to come up with a version of the |
|
I'll take a look. |
|
So, I was going to port over the special case from here but it's complicated and this one seems to produce exactly the same results. :) |
mourner
added a commit
that referenced
this pull request
Aug 7, 2015
FlyTo with targetCenter == currentCenter not animated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see http://jsfiddle.net/v1so6m56/4/
If targetCenter is the same of currenteCenter, the parameter u1 (the distance between "to" and "from") is 0.
The proposed patch resolve this by forcing the distance to 1.