Prevent division by zero in FlyTo when currentCenter == targetCenter #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ L.Map.include({ | |||
| rho2 = rho * rho; | |||
|
|
|||
| function r(i) { | |||
| var b = (w1 * w1 - w0 * w0 + (i ? -1 : 1) * rho2 * rho2 * u1 * u1) / (2 * (i ? w1 : w0) * rho2 * u1); | |||
| var b = (w1 * w1 - w0 * w0 + (i ? -1 : 1) * rho2 * rho2 * u1) / (2 * (i ? w1 : w0) * rho2); | |||
There was a problem hiding this comment.
what's going on here? it can't be removed like that because of the left part of the formula
There was a problem hiding this comment.
Oh, wait, I've misread the left part. I was assuming u1 multiplied everything.
IvanSanchez
force-pushed
the
flyto-dividebyzero
branch
from
3c6cfaa
to
f89d368
Compare
|
I don't think this solution is working: |
|
Sorry, you changed your implementation while I was writing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #3663. Skip division by the distance from start to end when that distance is zero.