Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS z-index bug #6634

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CSS z-index bug #6634

wants to merge 1 commit into from

Conversation

ilblog
Copy link
Contributor

@ilblog ilblog commented May 3, 2019

Unfortunately a bug in Chrome browser does not respect CSS stacking context regarding z-index. Therefore tile-pane with 400 z-index overlays the stuff, that is even outside map container.

The patch is applied on https://windy.com and works flawlessly more than 1 month

With patch applied
Screenshot 2019-05-03 at 07 52 45

Without patch, original Leaflet's CSS
Screenshot 2019-05-03 at 07 52 53

Unfortunately a bug in Chrome browser does not respect CSS stacking context regarding z-index. Therefore tile-pane with 400 z-index overlays the stuff, that is even outside map container.
@IvanSanchez
Copy link
Member

Unfortunately a bug in Chrome browser

Which one?


Looks related to #3690

@johnd0e
Copy link
Collaborator

johnd0e commented Apr 17, 2020

@ilblog?

I've re-added .leaflet-pane { z-index: 400; } back on Windy.com haven't observed any difference.
Please provide some sample to reproduce the issue.

@Falke-Design Falke-Design added compatibility Cross-browser/device/environment compatibility needs more info labels Nov 14, 2021
@Malvoz
Copy link
Member

Malvoz commented Feb 10, 2022

I've re-added .leaflet-pane { z-index: 400; } back on Windy.com haven't observed any difference.

@johnd0e If I re-add the styles I see that all the controls disappear in Chrome.

Looks related to #3690

@IvanSanchez I can confirm that this PR would indeed fix that issue.

But it's not entirely clear to me what the implications would be if z-index was removed for leaflet-pane as this PR suggests. Could that introduce other problems?


Other fixes for the issue described here for windy.com:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Cross-browser/device/environment compatibility needs decision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants