Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove border styles in overflowing popups #8260

Merged
merged 3 commits into from May 24, 2022
Merged

Remove border styles in overflowing popups #8260

merged 3 commits into from May 24, 2022

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented May 23, 2022 •
edited by Falke-Design

Fix #6218.

@Malvoz Malvoz added this to the 1.9.0 milestone May 23, 2022
@Malvoz
Copy link
Member Author

Malvoz commented May 23, 2022 •
edited

IMO we should go ahead with this.

The border styles can be a bit unexpected, only used if maxHeight is set. And leaflet-popup-scrolled can still be styled with custom CSS.

@Malvoz Malvoz requested a review from Falke-Design May 23, 2022 09:42
@mourner mourner merged commit 714b9e2 into Leaflet:main May 24, 2022
@Malvoz Malvoz deleted the remove-horizontal-lines branch May 24, 2022 16:29
@someonewithpc someonewithpc mentioned this pull request Sep 30, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Falke-Design Falke-Design Falke-Design approved these changes

Assignees
No one assigned
Labels
needs decision ux
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Malvoz @Falke-Design @mourner