-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support {-y}
for TileLayer
#8575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't checked the code but a test is needed anyway
@Falke-Design I need to add a test ? |
For some reason there was a expliciet test for Leaflet/spec/suites/layer/tile/TileLayerSpec.js Lines 327 to 345 in c33a57c
Added with: #4338 |
@Falke-Design This is what I understood - |
@mourner @IvanSanchez maybe you can take a look into this. The tile and rendering logic is still pretty hard for me |
@Falke-Design I reforked this repo. Should I open a new PR for this issue #8395 ? |
@ShivangMishra go for it |
modified TileLayer::getTileURL to support {-y} syntax from within infinite coordinate systems.
The change is safe - the only new behavior is supporting {-y} in some cases which previously were unsupported.
Fixes: #8395