Added support for {-y}tiled maps into infinite #8595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malvoz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8395.
@Falke-Design Please review.
Please note - There was a explicit test for {-y} to be not set on infinite crs. This test will fail.
The test was added due to the issue #4338 - the problem was that TMS "needs an upper bound for the CRS's Y coordinate, to be able to flip the tile row". In the case of infinite crs, we don't have an upper bound, that's probably why they added the check on {-y}.
In my PR, we don't use the upper bound, we simply set {-y} = (-1 * coords.y) - 1.
So, I think the test should be modified.
Any suggestions ? @jonkoops @mourner @IvanSanchez