Regex fix for newer version of node #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniemeyer
force-pushed
the
defect-autohost-regex-issue
branch
from
2cf7abf
to
5f4e672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue in newer versions of node when you have a child resource that uses a regex for the url. It seems related to changes with how escaped characters appear in the
toStringof a regex (https://bugs.chromium.org/p/v8/issues/detail?id=3229). The result was that in newer versions of Node, the final regex for a route was being prefixed multiple times.This fix is backwards compatible and will work in old (v0.12.x) versions and new. Changes were made to the tests to demonstrate where this was breaking.