Should preserve DOCTYPE when juiced #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses the same issue as #45, however with a test case added and all tests passing. |
madprgmr
added a commit
to madprgmr/grunt-juice-email
that referenced
this pull request
Dec 9, 2013
madprgmr
added a commit
to madprgmr/Email-Builder
that referenced
this pull request
Dec 16, 2013
Also moved the now-shared workaround to the 'utils' module.
Thanks!! Applied JSdoc DOCTYPE workaround to juice.inlineContent().
|
I merged this pull request (and made some other fixes) in my fork |
rauchg
added a commit
that referenced
this pull request
Oct 27, 2014
Should preserve DOCTYPE when juiced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a document is juiced, Juice should preserve the html DOCTYPE in the output.
Provides a fix for this issue plus a test case. All tests passing.