Fix tests and revert express pinning #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge in 3.0.0alpha1" Based on the discussion in pull request LearnBoost#22, I Assuming that the undescibed breaking change was the one fixed by my 09a3f84 commit. This reverts commit ba75906. Signed-off-by: Asbjørn Sloth Tønnesen <ast@veridu.com>
Repair the following damages after pull request LearnBoost#23: - As it turns out `deafult` doesn't have any special meaning in a switch statement. - After copy-pasting a fix from lib/up.js to test/up.js it is recommended to run that test. Signed-off-by: Asbjørn Sloth Tønnesen <ast@veridu.com>
test/up.js only expects and supports one worker: > // the spawn process will start an up server with 1 worker and > // will send us the pid over a net channel Signed-off-by: Asbjørn Sloth Tønnesen <ast@veridu.com>
|
Rebased on to new 0.2.0 master, and still parsing all tests. Whats the hold up on merging this? |
rauchg
added a commit
that referenced
this pull request
Jun 25, 2012
Fix tests and revert express pinning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix existing tests, before adding new ones.
Also revert Express pinning because we now have support for Express 3.x