Fix tests and revert express pinning #30

merged 3 commits into from Jun 25, 2012


None yet
2 participants

mugami-ast commented May 25, 2012

Fix existing tests, before adding new ones.

Also revert Express pinning because we now have support for Express 3.x

mugami-ast added some commits May 25, 2012

@mugami-ast mugami-ast Revert "pegged express devDependency version because of breaking chan…
…ge in 3.0.0alpha1"

Based on the discussion in pull request #22, I Assuming that the
undescibed breaking change was the one fixed by my 09a3f84 commit.

This reverts commit ba75906.

Signed-off-by: Asbjørn Sloth Tønnesen <>
@mugami-ast mugami-ast Regain non-windows compatibility
Repair the following damages after pull request #23:

- As it turns out `deafult` doesn't have any
  special meaning in a switch statement.

- After copy-pasting a fix from lib/up.js to test/up.js
  it is recommended to run that test.

Signed-off-by: Asbjørn Sloth Tønnesen <>
@mugami-ast mugami-ast Restrict the suicide test to only spawn 1 worker
test/up.js only expects and supports one worker:
> // the spawn process will start an up server with 1 worker and
> // will send us the pid over a net channel

Signed-off-by: Asbjørn Sloth Tønnesen <>

mugami-ast commented Jun 21, 2012

Rebased on to new 0.2.0 master, and still parsing all tests. Whats the hold up on merging this?

rauchg merged commit 8db0860 into LearnBoost:master Jun 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment