Add support for asynchronous worker startup #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty hot. Needs a test for ultimate hawtness |
|
I omitted the test because the existing tests were broken. I have rebased this branch onto pull request #30, so only the last 2 commits are unique for this pull request. |
|
Rebased on to new 0.2.0 master, and still parsing all tests. Whats the hold up on merging this? |
This adds a new option called assumeReady (default: true) that controls whether up should automatically add the new worker to the pool, or if it is up to the worker to asynchronous tell up when it is ready for to handle new requests. Signed-off-by: Asbjørn Sloth Tønnesen <ast@veridu.com>
Add 2 tests for testing the support for both synchronous and asynchronous worker spawning. Signed-off-by: Asbjørn Sloth Tønnesen <ast@veridu.com>
|
Rebased onto new 0.2.1 master |
rauchg
added a commit
that referenced
this pull request
Jun 26, 2012
Add support for asynchronous worker startup
|
Hi guys - is there any reason why this feature isn't in the npm package of up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option called assumeReady (default: true)
that controls whether up should automatically add the new worker
to the pool, or if it is up to the worker to asynchronous tell
up when it is ready for to handle new requests.
Signed-off-by: Asbjørn Sloth Tønnesen ast@veridu.com