Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Exports): Expire and delete exports to avoid clutter. (LL-100) #1215

Closed
wants to merge 34 commits into from
Closed

feat(Exports): Expire and delete exports to avoid clutter. (LL-100) #1215

wants to merge 34 commits into from

Conversation

cbishopvelti
Copy link
Contributor

@cbishopvelti cbishopvelti commented Jul 31, 2018 •
edited by ryasmi
Loading

@ht2 ht2 changed the title Issue ll 582b LL-582 Expire and delete exports Jul 31, 2018
@ht2 ht2 mentioned this pull request Aug 1, 2018
Closed
@ht2 ht2 added the QA NEEDED label Aug 1, 2018
ryasmi
ryasmi requested changes Aug 8, 2018
View reviewed changes
Copy link
Member

@ryasmi ryasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly okay, few things I would have done differently. Overall we need to make sure we use better variable names.

cli/src/commands/expirationExports.js Outdated Show resolved Hide resolved
cli/src/commands/expirationExports.js Outdated Show resolved Hide resolved
cli/src/commands/expirationExports.js Outdated Show resolved Hide resolved
lib/models/download.js Outdated Show resolved Hide resolved
lib/models/download.js Outdated Show resolved Hide resolved
ui/src/containers/SubOrgForm/index.js Outdated Show resolved Hide resolved
ui/src/containers/SubOrgForm/index.js Outdated Show resolved Hide resolved
ui/src/redux/create.js Outdated Show resolved Hide resolved
ui/src/redux/create.js Outdated Show resolved Hide resolved
ui/src/redux/create.js Outdated Show resolved Hide resolved
@ht2
Copy link
Contributor

ht2 commented Feb 13, 2019

Kill the package-lock.json!

@ryasmi ryasmi removed the Part: API label Feb 27, 2019
@ryasmi ryasmi self-requested a review March 4, 2019 16:17
@ryasmi ryasmi assigned ryasmi and unassigned h-kanazawa Mar 4, 2019
ht2
ht2 previously requested changes Mar 5, 2019
View reviewed changes
ui/src/redux/create.js Outdated Show resolved Hide resolved
ryasmi
ryasmi reviewed Mar 5, 2019
View reviewed changes
ui/src/redux/create.js Outdated Show resolved Hide resolved
@ryasmi
Copy link
Member

ryasmi commented Mar 5, 2019

@ht2

Kill the package-lock.json!

Done 👍

@ryasmi ryasmi removed their assignment Mar 5, 2019
@ryasmi
Copy link
Member

ryasmi commented Mar 12, 2019

Note to self: This is actually QA failed on the QA YT board, but James and Asahd need time to write down what's wrong.

@ryasmi ryasmi unassigned ht2 Jun 17, 2019
@ryasmi ryasmi changed the title LL-582 Expire and delete exports feat(Exports): Expire and delete exports to avoid clutter. (LL-100) Sep 6, 2019
@ryasmi
Copy link
Member

ryasmi commented May 13, 2020

Closing because it's stale.

@ryasmi ryasmi closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryasmi ryasmi ryasmi approved these changes

@h-kanazawa h-kanazawa h-kanazawa left review comments

@ht2 ht2 ht2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cbishopvelti @ht2 @ryasmi @h-kanazawa @asahd @happy-machine