Fixes fd leak in leasedb (ticket #2015) #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brian correctly diagnozed this issue and suggested the fix in Weekly Dev Chat of 2013-07-09. This patch has been manually tested by Zooko using his fdleakfinder and a unit test has been added to ensure that database connections are properly closed. Without this patch, the 1819-cloud-merge branch uses more than 1020 fds and will start failing on operating systems with a low fds limit. The portions affecting leasedb.py were written by Zooko and Daira.
ghost
assigned 
|
+1, will commit. |
exarkun
pushed a commit
that referenced
this pull request
Sep 12, 2017
Add a test for the non-numeric pidfile contents case
exarkun
pushed a commit
that referenced
this pull request
Aug 15, 2019
update client.py to use DEFAULT_MAX_SEGMENT_SIZE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brian correctly diagnozed this issue and suggested the fix in Weekly Dev
Chat of 2013-07-09. This patch has been manually tested by Zooko using his
fdleakfinder and a unit test has been added to ensure that database connections
are properly closed. Without this patch, the 1819-cloud-merge branch uses
more than 1020 fds and will start failing on operating systems with a low fds
limit.
The portions affecting leasedb.py were written by Zooko and Daira.