-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Fix" audio input source deactivation bug #605
Conversation
WalkthroughThe update to the audio effect code introduces a mechanism for managing the state of audio devices. A new attribute, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- ledfx/effects/audio.py (2 hunks)
Additional comments: 4
ledfx/effects/audio.py (4)
135-135: The
pending_deactivation
attribute has been added to theAudioInputSource
class. This attribute is used to manage the state of the audio device, particularly in relation to the bug mentioned in the PR description. The use of this attribute should be consistent and clear throughout the code.323-323: The
pending_deactivation
attribute is set toFalse
in thesubscribe
method before callingactivate
. This ensures that the audio device remains active when there are subscribers. It's important to verify that this attribute is being used correctly in all relevant parts of the code.330-338: Comments have been added to the
unsubscribe
method explaining why the audio device is not being deactivated. While this is a workaround for a bug in portaudio, it's important to ensure that this decision is documented and that any potential impacts on performance or resource usage are considered.320-341: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-500]
Overall, the changes in the file seem to be focused on managing the state of the audio device in response to subscription and unsubscription events. The introduction of the
pending_deactivation
attribute and the comments explaining the workaround for the portaudio bug are the key changes. It is important to ensure that these changes do not negatively impact the performance or resource management of the software, and that they are consistent with the rest of the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- ledfx/effects/audio.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- ledfx/effects/audio.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- ledfx/effects/audio.py (3 hunks)
Additional comments: 3
ledfx/effects/audio.py (3)
37-37: The introduction of the
_timer
attribute is a good approach to handle the delayed deactivation of the audio source. This should help in managing the state of the audio device effectively.324-326: The cancellation of the existing timer in the
subscribe
method is a good practice to ensure that no unnecessary deactivation checks are pending when a new subscription is made.341-348: The
check_and_deactivate
method correctly checks if the timer is not None before canceling it and sets it to None after. It also checks the subscriber count before deactivating the audio source. This is a good implementation to ensure that the audio source is not deactivated prematurely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- ledfx/effects/audio.py (4 hunks)
Additional comments: 3
ledfx/effects/audio.py (3)
37-37: The addition of the
_timer
attribute to theAudioInputSource
class is noted. This attribute is used for managing delayed deactivation of the audio input source.328-330: The code correctly cancels any existing timer when a new subscription is made. This ensures that the audio input source is not prematurely deactivated.
345-352: The
check_and_deactivate
method correctly cancels the timer and sets it toNone
before checking if the audio input source should be deactivated. This is a good practice to ensure that the timer does not trigger the method again after it has already been called.
commit 43622b38fecb8367589963588d2682de8635d1d6 Merge: 9f3d7db3 d839e290 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 17:59:37 2024 +1100 Merge pull request #635 from LedFx/harden_clone Fix initialization of self.sct in Clone class commit d839e290336d67c0597ed2191d98c0f125d27b9f Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 17:56:26 2024 +1100 Fix initialization of self.sct in Clone class commit 9f3d7db30d0258e67df2fbe2528c0bdf01913c48 Merge: 522d6a29 573dcd2c Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 17:44:48 2024 +1100 Merge pull request #634 from LedFx/fix_pypi_event_name Fix optional dependency name and remove bokeh (dev dependency) commit 522d6a297e7e570c33a772fd3c3324b95da66182 Merge: 1c77f6c5 e62172b6 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 17:29:16 2024 +1100 Merge pull request #633 from LedFx/update_sentry_env_paths Update Sentry configuration based on environment commit e62172b6f3ef4d3386edde7bd6148f3f0564f78e Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri Jan 19 06:27:10 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 031a142f4c15774a6e4d8f84f7b4906e21c3f4ca Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 17:25:19 2024 +1100 Update Sentry configuration based on environment commit 573dcd2cc7f4f4c36c850c6644a6c0f89224b9ff Merge: 387da71e 48279fb2 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 16:52:33 2024 +1100 Merge pull request #632 from LedFx:fix_mbedtls_name Fix optional dependency name and remove bokeh (dev dependency) commit 48279fb23fea04d56446c00df5ab0b09941e8c8f Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 16:52:14 2024 +1100 Fix optional dependency name and remove bokeh (dev dependency) commit 1c77f6c522662103032ecdfc0d6c0f51a6665653 Merge: e81c32a3 387da71e Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 16:30:44 2024 +1100 Merge pull request #631 from LedFx:fix_pypi_event_name Fix pypi event name from push to release commit 387da71e19229970fc6c3eee783e4491cae503e5 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 16:29:38 2024 +1100 Fix pypi event name from push to release commit e81c32a310051a96c4596faf49ad73f7895509ba Merge: 20410e5d dea96d15 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 15:55:29 2024 +1100 Merge pull request #630 from LedFx:update_pypi_workflow Remove unnecessary step and update PyPI API token commit dea96d153354ad89cc2c596f8acc1635aa061e19 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 15:55:07 2024 +1100 Remove unnecessary step and update PyPI API token commit 20410e5d991f97227f21aae63d5f69adba18785f Merge: 609655d7 297000d6 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 15:47:45 2024 +1100 Merge pull request #629 from LedFx/renovate/actions-setup-python-5.x Update actions/setup-python action to v5 commit 609655d713be9bcf6768b07a4323e8479480d005 Merge: 57f38f0d 9f17bede Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 15:47:34 2024 +1100 Merge pull request #628 from LedFx/renovate/actions-checkout-4.x Update actions/checkout action to v4 commit 297000d60309884927e89f4c601df7b0520a057d Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Jan 19 04:28:58 2024 +0000 Update actions/setup-python action to v5 commit 9f17bedea8a8e21da60d42ef43eb69520dbe81fb Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Jan 19 04:28:54 2024 +0000 Update actions/checkout action to v4 commit 57f38f0da043db3bda178c8f9784112aaf7c936f Merge: 3eff7c68 1fa6e245 Author: Yeon Vinzenz Varapragasam <trusted.yeon@gmail.com> Date: Fri Jan 19 05:28:24 2024 +0100 Merge pull request #627 from LedFx/make_mbedtls_optional Update optional flag for python-mbedtls package commit 1fa6e245fbd4462daba3709b65c99329f34a9b06 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 15:19:22 2024 +1100 Add prod and dev deps, update spec, update pypi build commit 3eff7c68199af0a90fe33fe6a0a08d2b4daa6f79 Merge: 081a1381 ee36ad97 Author: bigredfrog <anthony.tod@gmail.com> Date: Thu Jan 18 21:01:35 2024 -0500 Merge pull request #625 from bigredfrog/clone3 More defensive clone implementation commit 743a539343e675dec99da8127502241df18b403c Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 19 12:33:54 2024 +1100 Update optional flag for python-mbedtls package commit 081a13812d922f9810a93b8ba01c8f7099019486 Merge: cce7b3c7 fa738bd8 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 18 21:14:07 2024 +1100 Merge pull request #591 from LedFx/enhance_rain_with_pulse Add strip pulsing feature to RainAudioEffect class commit cce7b3c7fb47b9530c46efb187510910774e702a Merge: 07eee568 40e5e1ca Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 18 21:13:33 2024 +1100 Merge pull request #619 from LedFx/melbank_hardening Fix NaN values in melbank array commit ee36ad9764651af406a56a94d838304bb361a7d1 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 18 03:14:19 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 0a30bc90a730d8eec5057fb064415d001053f3ad Merge: 5faae232 eb84644b Author: atod <anthony.tod@gmail.com> Date: Wed Jan 17 22:14:01 2024 -0500 Merge remote-tracking branch 'origin/clone3' into clone3 commit 5faae232572bfad15fc90f455396519dd4ba392a Author: atod <anthony.tod@gmail.com> Date: Wed Jan 17 22:13:50 2024 -0500 More defensive clone implementation commit eb84644b19f69f7cdcc70aa5dc48aa327e982f91 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 18 03:10:08 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 16ec02d36ec1b8d5a87dd1682a850683cb3decf2 Author: atod <anthony.tod@gmail.com> Date: Wed Jan 17 22:06:50 2024 -0500 More defensive clone implementation commit 07eee568f45435afa3dfe5453dcaaee49336a8a0 Merge: f85dd118 2d585fcf Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 18 04:16:18 2024 +1100 Merge pull request #618 from shauneccles/perf_analysis_class Add PerformanceAnalysis class for comparing function performance commit f85dd11834982e518b059d75c119cf63b1b7d861 Merge: bdb8d479 bbc63310 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 18 04:15:12 2024 +1100 Merge pull request #610 from LedFx/renovate/sphinxcontrib-websupport-1.x Update dependency sphinxcontrib-websupport to v1.2.7 commit bdb8d479bd5ca060b6a80187bd28e4f26a2e3d09 Merge: e5327884 c1e63c60 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 18 04:14:38 2024 +1100 Merge pull request #623 from LedFx/renovate/actions-cache-4.x Update actions/cache action to v4 commit c1e63c6035a4f3cf99c8724876bb20ca57924f28 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jan 17 16:18:01 2024 +0000 Update actions/cache action to v4 commit e532788442ed6b5705d6e19e281e75c245759228 Merge: 31b5193d 154b4f76 Author: bigredfrog <anthony.tod@gmail.com> Date: Wed Jan 17 00:06:22 2024 -0500 Merge pull request #620 from bigredfrog/heal_presets Autoheal hard coded presets and custom presets commit 31b5193d792f0a7a59bbfa9fdb05a46bbff69048 Merge: dfa883c1 3394cfbf Author: Yeon Vinzenz Varapragasam <trusted.yeon@gmail.com> Date: Wed Jan 17 00:05:23 2024 +0100 Merge pull request #622 from LedFx/new-frontend Release v2.0.89 commit 3394cfbfec9f7550ee534c56bc3ab67789da1b2b Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue Jan 16 05:01:58 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 879560957cee4d40d899d12e410f63c7a26fcd48 Author: YeonV <YeonV@users.noreply.github.com> Date: Tue Jan 16 05:01:20 2024 +0000 [new-frontend] v2.0.89 commit 154b4f761102e8f7437bccad80e7e04b94b91f2d Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue Jan 16 04:21:53 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 6335be9e509c876061e16a656a9b6fbf4e266519 Author: atod <anthony.tod@gmail.com> Date: Mon Jan 15 23:19:04 2024 -0500 Use the schema default values to auto heal hard coded presets and user cusotm presets with default values for missing keys. commit 40e5e1cac46b3d19db6e0e7761236bb632116ddb Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon Jan 15 21:12:31 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 6452b657ab6cf6ed8b64894ef4a28c07f521f8f0 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Tue Jan 16 08:12:17 2024 +1100 Replace print with logging statement Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit 39576f16fbfc6c185923d604856fe916f419f18d Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Tue Jan 16 07:50:00 2024 +1100 Fix NaN values in melbank array commit 2d585fcfd41aa68d82ce1c9579ae2b2acd8bac65 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Tue Jan 16 06:57:25 2024 +1100 Add PerformanceAnalysis class for comparing function performance commit dfa883c19b46e742dd158ec2e803b17a044bf78d Merge: fa205727 f8de9794 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Mon Jan 15 13:01:04 2024 +1100 Merge pull request #616 from LedFx/optimise_rainbow Refactor fill_rainbow function to improve performance (and sprinkle docs) commit f8de979410f9301bdec96ab2a4e955096d79288b Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Mon Jan 15 12:55:08 2024 +1100 Refactor fill_rainbow function to improve performance (and sprinkle docs) commit fa205727591620be01a107fc667b23b4409e217e Merge: 61e8587b 7d6a2b92 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Mon Jan 15 12:39:06 2024 +1100 Merge pull request #615 from LedFx/fix_linting_issues Fix formatting issues in code commit 7d6a2b922e4b45431d4aa2339d9e18ffb53dfd26 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Mon Jan 15 12:35:46 2024 +1100 Fix formatting issues in code - not sure why pre-commit hasn't picked these up commit 61e8587b0b0f0a511f94eaa247e24c53ffe27381 Merge: 27715896 ee58f51f Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 13 19:48:19 2024 +1100 Merge pull request #573 from bigredfrog/changerows Reconfigure effect panel size when virtual rows changes commit bbc63310117a3b77765f2b675430b19ec005cd56 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Jan 13 03:52:19 2024 +0000 Update dependency sphinxcontrib-websupport to v1.2.7 commit 27715896ec27cf0e70cf48c1b2298e1e9b901410 Merge: f155c928 c8ce3612 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 13 14:52:02 2024 +1100 Merge pull request #609 from LedFx:add_offline_debug_entrypoints Update launch.json and remove tasks.json commit c8ce3612ab9a7af08e38cec707de1c7a631bfb18 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 13 14:51:06 2024 +1100 Update launch.json and remove tasks.json commit f155c928947182f89bef4fbf18c6f2fb2755af8a Merge: eb4a5027 5ee11c4e Author: Yeon Vinzenz Varapragasam <trusted.yeon@gmail.com> Date: Fri Jan 12 12:49:33 2024 +0100 Merge pull request #607 from LedFx/new-frontend Release v2.0.88 commit 5ee11c4efb9b65fccb262b3eb3834fad0b9baaf1 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri Jan 12 04:57:30 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 544435b3c785644ea0899fff3270e4902db7e0bd Author: YeonV <YeonV@users.noreply.github.com> Date: Fri Jan 12 04:56:45 2024 +0000 [new-frontend] v2.0.88 commit ee58f51f6558b989db899fe8494189ef8996d5df Merge: 37412697 264d835f Author: atod <anthony.tod@gmail.com> Date: Thu Jan 11 23:43:26 2024 -0500 Merge remote-tracking branch 'origin/changerows' into changerows commit 37412697ccf1252885795671fdeb339aefe56108 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 11 23:43:15 2024 -0500 better notification to twod effect of need to run do_once via set_init commit 264d835fb3e936724107e09b5120fdb3d52c02ff Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri Jan 12 04:41:58 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit e811862e10ae4e87bcd5097a495b2cda4b7d9eba Author: atod <anthony.tod@gmail.com> Date: Thu Jan 11 23:41:32 2024 -0500 better notification to twod effect of need to run do_once via set_init commit 62d9228ed0df89f487421b34553da3c330fe54ec Merge: fda3d648 eb4a5027 Author: bigredfrog <anthony.tod@gmail.com> Date: Thu Jan 11 22:41:40 2024 -0500 Merge branch 'LedFx:main' into changerows commit eb4a5027690e2e281fe2c1c4036847f258734627 Merge: fb4a6c2d 725e9c2d Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 12 09:52:23 2024 +1100 Merge pull request #606 from LedFx/thread_naming Add thread naming to TemporalEffect and Virtual classes commit 725e9c2deead2ca07bf3cfe1c3d61353e9f54b4a Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 12 09:05:02 2024 +1100 Add thread naming to TemporalEffect and Virtual classes commit fb4a6c2db70889858ca065d1290e4efec5d48b4e Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 11 23:43:47 2024 +1100 "Fix" audio input source deactivation bug (#605) * Add timer to check and deactivate audio input source after 5s of inactivity * Add delay to audio system shutdown on LedFx exit commit 3b947c88549211d5991b4a94a40ab90a024d3a34 Merge: 15bb4f20 9d5a2181 Author: bigredfrog <anthony.tod@gmail.com> Date: Wed Jan 10 23:09:25 2024 -0500 Merge pull request #604 from bigredfrog/keybeat_fix fix clip value function for keybeat commit fda3d648804af5cc501149a361a379fc34534ba7 Author: atod <anthony.tod@gmail.com> Date: Wed Jan 10 22:46:14 2024 -0500 better notification to twod effect of need to run do_once via init commit 71efcf6249d8cea04c4ecaa3377295b8957d246c Merge: 8cb6ffeb 15bb4f20 Author: bigredfrog <anthony.tod@gmail.com> Date: Wed Jan 10 22:34:08 2024 -0500 Merge branch 'LedFx:main' into changerows commit 9d5a2181e6e0154f0d158a6d6b325b6027adbfc8 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 11 03:16:58 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit a7c8749365487e42602a674ca6abb47942a7eb94 Author: atod <anthony.tod@gmail.com> Date: Wed Jan 10 22:14:37 2024 -0500 fix clip value function for keybeat commit 15bb4f20a2f5a010e42fbb80f621dbfdf28d1195 Merge: 6205751f 88d70775 Author: bigredfrog <anthony.tod@gmail.com> Date: Wed Jan 10 17:23:41 2024 -0500 Merge pull request #602 from bigredfrog/sentry_git_try Protect against no git for senty commit 6205751f190a87c17ab1b4650458996e5cf3f00a Merge: bde8b657 70ba2d3c Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 11 08:19:55 2024 +1100 Merge pull request #599 from LedFx/renovate/cython-3.x-lockfile Update dependency cython to v3.0.8 commit bde8b657914b1eed88665c718916cd13b76e6441 Merge: 16e648de fe787535 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 11 08:19:40 2024 +1100 Merge pull request #600 from LedFx/renovate/sentry-sdk-1.x Update dependency sentry-sdk to v1.39.2 commit 88d7077534828cdb72ba1ffc85f739eb10b65cc9 Merge: 77ae8766 a36764d0 Author: atod <anthony.tod@gmail.com> Date: Wed Jan 10 16:19:23 2024 -0500 Merge remote-tracking branch 'origin/sentry_git_try' into sentry_git_try commit 77ae876638333ce30c9e48ef1e9be4dfe4c494a5 Author: atod <anthony.tod@gmail.com> Date: Wed Jan 10 16:18:55 2024 -0500 protect sentry git enquirey in dev mode from failing to find git for commit extraction commit a36764d0aaec64fcd634454927ae74c07808ab8f Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed Jan 10 20:58:35 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 448b549f8083949c7ac727b78107f951340d8db5 Author: atod <anthony.tod@gmail.com> Date: Wed Jan 10 15:21:22 2024 -0500 protect sentry git enquirey in dev mode from failing to find git for commit extraction commit fe787535cdf7c75fa11e514e201fa7bea02f0651 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jan 10 12:17:25 2024 +0000 Update dependency sentry-sdk to v1.39.2 commit 70ba2d3cd5bff35cca497f97035f125eb90ca0d7 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jan 10 12:17:19 2024 +0000 Update dependency cython to v3.0.8 commit 16e648ded55dd535a70553a7c5a86f0c93d928ae Merge: f3cd7d8a 5d15c774 Author: Yeon Vinzenz Varapragasam <trusted.yeon@gmail.com> Date: Wed Jan 10 00:29:03 2024 +0100 Merge pull request #597 from LedFx/new-frontend Release v2.0.87 commit 5d15c7743ba7010167b1baddfa209064e861abf6 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue Jan 9 21:27:49 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit fbc635801715585da2b85e4f4497bb5cb8fbec71 Author: YeonV <YeonV@users.noreply.github.com> Date: Tue Jan 9 21:26:50 2024 +0000 [new-frontend] v2.0.87 commit f3cd7d8a935371afa87872aa5dbfc2a38c956e14 Merge: 4fa0347d d199abb4 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Tue Jan 9 10:01:53 2024 +1100 Merge pull request #596 from bigredfrog/fix_bands_matrix fix reversing bands when band pixel counts are not equal commit d199abb470e1c2685ba3cc51fcecd465a03a1191 Author: atod <anthony.tod@gmail.com> Date: Mon Jan 8 17:51:11 2024 -0500 fix reversing bands when band pixel counts are not equeal. np.flip requires equal array lenghts and will crash. commit 4fa0347db98f0b90959e5f15bffaf95b0b26256c Merge: 42dce159 0457ce44 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Tue Jan 9 08:37:50 2024 +1100 Merge pull request #595 from LedFx/pre-commit-ci-update-config [pre-commit.ci] pre-commit autoupdate commit 0457ce4417c5ba7778723d8d07d164f05bcc2d78 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon Jan 8 21:27:37 2024 +0000 [pre-commit.ci] pre-commit autoupdate updates: - [github.com/PyCQA/flake8: 6.1.0 → 7.0.0](https://github.com/PyCQA/flake8/compare/6.1.0...7.0.0) commit 42dce159dabb9cbdb38ddefccd9b3aca88097f0a Merge: f2a96c0d 53aa0ba5 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Tue Jan 9 06:53:55 2024 +1100 Merge pull request #594 from bigredfrog/presets_default Automagical "reset" default presets for effects commit 53aa0ba5d057a2b117efe04b9acf7ec6641e82ae Merge: 8de225b2 b4457016 Author: atod <anthony.tod@gmail.com> Date: Sun Jan 7 17:10:32 2024 -0500 Merge remote-tracking branch 'origin/presets_default' into presets_default commit 8de225b26cec6d466862df34e1dd37dee02994d1 Author: atod <anthony.tod@gmail.com> Date: Sun Jan 7 17:10:20 2024 -0500 moved from default to reset removed all hard coded reset commit b4457016cb0aade3087d7d07eee7fc16a7875d14 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sun Jan 7 21:16:41 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 68543d04e5fdfc1f9f6ab00888e8fa9451446e83 Author: atod <anthony.tod@gmail.com> Date: Sun Jan 7 16:16:11 2024 -0500 add some equalizer2d presets while testing commit 709ee512c4d8e83ab726e1bbbd4d07310a4bf1ca Merge: 48dcfdd6 f2a96c0d Author: bigredfrog <anthony.tod@gmail.com> Date: Sun Jan 7 16:00:13 2024 -0500 Merge branch 'LedFx:main' into presets_default commit f2a96c0d367b3c8360890da495545dca57c577d3 Merge: 7fa359df bca43470 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Mon Jan 8 07:54:22 2024 +1100 Merge pull request #589 from bigredfrog/whatsnext add ring effect commit 48dcfdd6037749a51c81af9e2b55bca3e8b55f89 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sun Jan 7 19:49:07 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit a7cc5374f318c469c97e9956b549cd6effd641f0 Author: atod <anthony.tod@gmail.com> Date: Sun Jan 7 14:48:45 2024 -0500 fix for effects with no presets at all commit 9422f7c3d3d7d6fa61272a34a85c53383ea2f369 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sun Jan 7 19:41:58 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit c6f83c258414b0e704cfe71671742b8076a1afd8 Merge: b673e75f 7fa359df Author: bigredfrog <anthony.tod@gmail.com> Date: Sun Jan 7 14:41:42 2024 -0500 Merge branch 'main' into presets_default commit b673e75fd421c1730021c1f193335cc9e1468e62 Author: atod <anthony.tod@gmail.com> Date: Sun Jan 7 14:37:04 2024 -0500 Add default config generation, inject into api calls, support selection. presets and virtual_presets commit bca43470837935f9c01975926b9c4789431d4618 Merge: a3d16633 7fa359df Author: bigredfrog <anthony.tod@gmail.com> Date: Sun Jan 7 11:22:42 2024 -0500 Merge branch 'LedFx:main' into whatsnext commit 7fa359dfd75953e5857573482c65af790268064a Merge: 5c200a29 594ea88d Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sun Jan 7 18:04:39 2024 +1100 Merge pull request #588 from shauneccles/api_cleaning Refactor API endpoints commit 5c200a2973330aeabd0edc4eecb9287393281406 Merge: 941dffef 0898abd7 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sun Jan 7 17:31:06 2024 +1100 Merge pull request #593 from LedFx/harden_invalid_config_handling Catch invalid schemas in Effect class commit a3d16633ffb64afdeaa711586c74e83b95c8cb88 Author: atod <anthony.tod@gmail.com> Date: Sun Jan 7 01:16:29 2024 -0500 clean up reset persist spin_value commit 4469641e928fc6cc2088c6ca94b19754220e7347 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sun Jan 7 04:11:54 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit e065f5177c624c271f96c1426a31d66bc1f3469c Merge: a9eec2b6 b5be6da3 Author: atod <anthony.tod@gmail.com> Date: Sat Jan 6 23:11:34 2024 -0500 Merge remote-tracking branch 'origin/whatsnext' into whatsnext commit a9eec2b65dc706e0f080922b5b122bef661d9eab Author: atod <anthony.tod@gmail.com> Date: Sat Jan 6 23:11:21 2024 -0500 refactor power_funcs, add spin impulse implementation commit b5be6da356719a86bacc6c73ae18e86ac55064b0 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sat Jan 6 23:37:58 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 7e8d73b1207bde4c6c908000304c2eeeb2e1fd33 Merge: bb71b673 4a5b90a2 Author: atod <anthony.tod@gmail.com> Date: Sat Jan 6 18:37:32 2024 -0500 Merge remote-tracking branch 'origin/whatsnext' into whatsnext commit bb71b673bce0e60f87da2876b3db554927885e69 Author: atod <anthony.tod@gmail.com> Date: Sat Jan 6 18:35:37 2024 -0500 refactor, add spin commit 0898abd7d310ee6807a46b9a42b92e3952d36693 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sun Jan 7 08:32:45 2024 +1100 Catch invalid schemas in Effect class commit 594ea88dec2e3f36edf3b4aaf6f92e4e5bd2b0fe Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 22:27:41 2024 +1100 Squashed commit of the following: commit 941dffefbe7c3cb64015199b6c483007b18dea00 Merge: 4dde3c55 03ecd4dc Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 21:48:22 2024 +1100 Merge pull request #592 from LedFx/zeroconf_event_listener Use LedFx_shutdown event in Zeroconf implementation commit 4dde3c55da6dc7954efd96482fc6c6f36372ceb5 Merge: 3a095add ecb31ab8 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 21:13:59 2024 +1100 Merge pull request #510 from mariusCZ/webaudio-base64 Webaudio base64. commit ecb31ab885eb473db094d5dc79f7d7139cc0775c Merge: ae04a500 3a095add Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Sat Jan 6 11:02:36 2024 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit ae04a5008e05e989a348965a9c2a23361d9ca5af Author: mariusCZ <m.cizauskas38@gmail.com> Date: Sat Jan 6 11:01:20 2024 +0100 Add webaudio docs. commit 03ecd4dccc3335b78d64d10b773b0c7a926010b8 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 20:56:43 2024 +1100 Remove zeroconf.async_close() and use shutdown event listener commit 3a095add3ffaba29a06982794c97f835411e1e6e Merge: 1c727c44 488598e9 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 18:28:12 2024 +1100 Merge pull request #590 from LedFx:remove_devcontainer Delete old unmaintained devcontainer commit 488598e9a65d9338cdc867b14462c6c4f46ea445 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 18:21:22 2024 +1100 Delete old unmaintained devcontainer commit 82f0aa5e48d7aaba188481abdeb75658cc84e778 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Fri Jan 5 15:45:11 2024 +0100 Try fix merge conflict, remove unused import. commit 6bfba59c762fcc6c5228714c3b28c91339535395 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Fri Jan 5 15:41:16 2024 +0100 Make max value global constant. commit 1c727c442337bc101b6eb050278a22fc4895e07f Merge: 6fb1fa67 62d7a329 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 5 16:49:56 2024 +1100 Merge pull request #587 from LedFx/renovate/flake8-7.x Update dependency flake8 to v7 commit 62d7a3294cb337fe121ae66bdd308299401f0a94 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Jan 5 02:23:05 2024 +0000 Update dependency flake8 to v7 commit 6fb1fa674973f491ea9364735d657953405a0610 Merge: 147e3c5b 6cffcbdf Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 5 13:22:05 2024 +1100 Merge pull request #586 from bigredfrog/gifresize Added GifBase class to inherit resizing commit 6cffcbdf4fca3b00992fc92237330525f85e2681 Merge: 74d77a93 893bccd0 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 21:10:09 2024 -0500 Merge remote-tracking branch 'origin/gifresize' into gifresize commit 74d77a9349ca0cb2f30514c2042822b8678dc52b Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 21:09:51 2024 -0500 cleanup commit 893bccd05192de9729ed6ca16e9325df7b928b58 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri Jan 5 02:07:16 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 7a593db7c4660e4904f02c1f401d8a69557e1591 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 21:05:06 2024 -0500 switch sentry config to IS_RELEASE commit 7f46bc2e08fb3fb8dcd0db63446cca9763658d13 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 19:51:12 2024 -0500 start cutting up for gifbase commit 147e3c5b0ddec535a7d367878759ac417e99f542 Merge: 45d95d7e 91cc4424 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 5 10:45:41 2024 +1100 Merge pull request #582 from bigredfrog/adddjbird Add dj bird to keybeat presets commit b5f7dd925f05ba3836721efafb39bff2613faafd Merge: 1b50aec2 cc8b9b23 Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Thu Jan 4 10:01:57 2024 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit 91cc442472913c8d3793b751f0a6e23d2ab40fce Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 4 01:58:45 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit e3ece6e852e3ce2b4b4fc9332d228b5e6b1dea70 Merge: 05dea19e 30d81c5c Author: atod <anthony.tod@gmail.com> Date: Wed Jan 3 20:58:25 2024 -0500 Merge remote-tracking branch 'origin/adddjbird' into adddjbird commit 05dea19eedba3245a45577c14f5f10a4bcbf0705 Author: atod <anthony.tod@gmail.com> Date: Wed Jan 3 20:58:11 2024 -0500 Fix up reset for template2d so its easier to debug with and tweak equaliser2d commit 30d81c5c665cd7e4ebaac3558ef47481ddbd1e95 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed Jan 3 23:34:50 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 8aa85c00b470d466e275b7dc7419159b070d5d6d Author: atod <anthony.tod@gmail.com> Date: Wed Jan 3 18:33:24 2024 -0500 Add dj bird to keybeat presets commit 1b50aec2170d02ac82cdbb1327b33e3a3ea808f1 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sat Dec 16 16:54:00 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit d0547dc06d6e918be964bb59c32bab0b6610f37c Author: mariusCZ <m.cizauskas38@gmail.com> Date: Sat Dec 16 17:53:40 2023 +0100 Switch to pybase64. commit a3d40c6f12dfa7a4219339ebadd27edc1a4bf1f4 Merge: cf369b3b 60b70007 Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Fri Dec 15 09:15:19 2023 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit cf369b3b9ae9aaa4cd970983fe54da1ce82cdd7d Merge: 4d125890 de5cb343 Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Thu Dec 14 09:27:07 2023 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit 4d12589002e70e6c4328b0dcdf536c1cdabfae13 Merge: a8fdc2f0 a0cbb6cf Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Tue Dec 12 10:09:17 2023 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit a8fdc2f01e4f7c0a467f653df5d1cc203496de94 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon Dec 11 13:18:42 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit a6dd786d30d1510a9551a408cc4cf40af4858b04 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Mon Dec 11 14:15:39 2023 +0100 Some exception handling for base64 decoding. commit 0f04544ca53e14c4a74288c804aa555912ac806c Merge: 548d3ab9 fefc4b15 Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Mon Dec 11 13:46:47 2023 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit 548d3ab95e23ed8031ce661b1705c56b3285b517 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Mon Dec 11 11:51:14 2023 +0100 Add base64 data parsing for webaudio. commit 90f067b67bf94ee065e20150786c2998ca1bced2 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 22:20:25 2024 +1100 Fix merge conflict commit 4430785dcbec2340d174b802f47b248ffe42cd48 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 20:56:43 2024 +1100 Remove zeroconf.async_close() and use shutdown event listener commit f68f6e8ff0169f7fcca44fb697931293099c1201 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 18:21:22 2024 +1100 Delete old unmaintained devcontainer commit 91ac805ddba43637d99c48a2e7e36fbe5cc68c99 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Jan 5 02:23:05 2024 +0000 Update dependency flake8 to v7 commit dc95e8f3917efa8722eba6cbdf8cb3ea2183c215 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri Jan 5 02:07:16 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit ee9cef6b0a4b0fd41b1a461e2799bf1d8d75f631 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 21:05:06 2024 -0500 switch sentry config to IS_RELEASE commit a16fdfa5815465bf1e88b93b9ed25d60cda382dc Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 19:51:12 2024 -0500 start cutting up for gifbase commit 407d9fb93ca51ebbaae52ba726c9e5fa8dec9c62 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 4 01:58:45 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit f31cc5671a70720e1472286693da00e46db4be3f Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed Jan 3 23:34:50 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 6c1dacce4c4d94983e62ca7e54201ea21cdb624e Author: atod <anthony.tod@gmail.com> Date: Wed Jan 3 20:58:11 2024 -0500 Fix up reset for template2d so its easier to debug with and tweak equaliser2d commit 114b60041568bf2924fcda8b22d90483f957385f Author: atod <anthony.tod@gmail.com> Date: Wed Jan 3 18:33:24 2024 -0500 Add dj bird to keybeat presets commit f359fa32ff8bb407c3cbafd4699e77d4ab31c657 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Sat Jan 6 11:01:20 2024 +0100 Add webaudio docs. commit 64ed67b9fa5560f7159bb266cf784e8b2333afa4 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Fri Jan 5 15:45:11 2024 +0100 Try fix merge conflict, remove unused import. commit 91a4dd1c5d04be7d7dca75cc3600c6f8ab621d10 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Fri Jan 5 15:41:16 2024 +0100 Make max value global constant. commit ce74a17ffebf89e5a036352978a987f3bc738d06 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sat Dec 16 16:54:00 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 776bbe7f01f651455cd41a86236b2057466a29bd Author: mariusCZ <m.cizauskas38@gmail.com> Date: Sat Dec 16 17:53:40 2023 +0100 Switch to pybase64. commit db3a716b1a02b8ea1bca9609d0879e39e8fb7c8b Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon Dec 11 13:18:42 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 5d57025f93ea0c31b5bf5c4f7e52e1d14cfa42c2 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Mon Dec 11 14:15:39 2023 +0100 Some exception handling for base64 decoding. commit f6bd71a5f22bbdb2e51e3a9ccb0dc2022a18e579 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Mon Dec 11 11:51:14 2023 +0100 Add base64 data parsing for webaudio. commit 941dffefbe7c3cb64015199b6c483007b18dea00 Merge: 4dde3c55 03ecd4dc Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 21:48:22 2024 +1100 Merge pull request #592 from LedFx/zeroconf_event_listener Use LedFx_shutdown event in Zeroconf implementation commit 4dde3c55da6dc7954efd96482fc6c6f36372ceb5 Merge: 3a095add ecb31ab8 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 21:13:59 2024 +1100 Merge pull request #510 from mariusCZ/webaudio-base64 Webaudio base64. commit ecb31ab885eb473db094d5dc79f7d7139cc0775c Merge: ae04a500 3a095add Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Sat Jan 6 11:02:36 2024 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit ae04a5008e05e989a348965a9c2a23361d9ca5af Author: mariusCZ <m.cizauskas38@gmail.com> Date: Sat Jan 6 11:01:20 2024 +0100 Add webaudio docs. commit 03ecd4dccc3335b78d64d10b773b0c7a926010b8 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 20:56:43 2024 +1100 Remove zeroconf.async_close() and use shutdown event listener commit fa738bd8d0984101d1fb8da778684c884b6aa9c7 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 19:51:52 2024 +1100 Add strip pulsing feature to RainAudioEffect class commit 3a095add3ffaba29a06982794c97f835411e1e6e Merge: 1c727c44 488598e9 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 18:28:12 2024 +1100 Merge pull request #590 from LedFx:remove_devcontainer Delete old unmaintained devcontainer commit 488598e9a65d9338cdc867b14462c6c4f46ea445 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sat Jan 6 18:21:22 2024 +1100 Delete old unmaintained devcontainer commit 4a5b90a27e795e3ea3b98ec3422ff18eebac2ecf Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sat Jan 6 00:43:39 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 6026717502c53de4961458e7fb93cd8dcaca68cc Author: atod <anthony.tod@gmail.com> Date: Fri Jan 5 19:41:21 2024 -0500 add ring effect commit 82f0aa5e48d7aaba188481abdeb75658cc84e778 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Fri Jan 5 15:45:11 2024 +0100 Try fix merge conflict, remove unused import. commit 6bfba59c762fcc6c5228714c3b28c91339535395 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Fri Jan 5 15:41:16 2024 +0100 Make max value global constant. commit 1c727c442337bc101b6eb050278a22fc4895e07f Merge: 6fb1fa67 62d7a329 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 5 16:49:56 2024 +1100 Merge pull request #587 from LedFx/renovate/flake8-7.x Update dependency flake8 to v7 commit 0c9928c1ec268cdc61b151a90e181391c2ceacd6 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 5 16:38:13 2024 +1100 Rearrange API helper arguments and cleanup function calls commit fe5fdc0aef511dfa7bd1ea5f60d1e1ac2cd8a152 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 5 16:24:40 2024 +1100 Downgrade API logging to warning - don't need to send to sentry commit 451e2cb5a9166bbefe8d42550217898b8ed45ec9 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 5 16:08:15 2024 +1100 Refactor API endpoints and add docstrings commit 8a0e1f2a1fe88e7f1e0b26e75ef2359f0290bb93 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri Jan 5 02:07:16 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 2600cc8a68bfea9c3b49cfd19cb6a28fee1a9541 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 21:09:51 2024 -0500 cleanup commit 01cabd07f9b8ee9b0aff0e24a908be2b80866dd0 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 21:05:06 2024 -0500 switch sentry config to IS_RELEASE commit 39eec22cd4505f956d8be7a9fcc3c7999fbc6928 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 19:51:12 2024 -0500 start cutting up for gifbase commit 5c0db2136a5151b8674149d5b6e5efd87bcff233 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 4 01:58:45 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit db597c7fb4a64284bbb2de5f452ae44314de6d78 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed Jan 3 23:34:50 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 73313eb4452a719f5e06f85ffcd165b83af952c6 Author: atod <anthony.tod@gmail.com> Date: Wed Jan 3 20:58:11 2024 -0500 Fix up reset for template2d so its easier to debug with and tweak equaliser2d commit 1f8dea35eed43f9c288d896ffafafae0df1231c6 Author: atod <anthony.tod@gmail.com> Date: Wed Jan 3 18:33:24 2024 -0500 Add dj bird to keybeat presets commit e517e9c1535a097acae36d424764ff7256f98d7e Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 5 14:21:42 2024 +1100 Delete unused endpoints commit 62d7a3294cb337fe121ae66bdd308299401f0a94 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Jan 5 02:23:05 2024 +0000 Update dependency flake8 to v7 commit 6fb1fa674973f491ea9364735d657953405a0610 Merge: 147e3c5b 6cffcbdf Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 5 13:22:05 2024 +1100 Merge pull request #586 from bigredfrog/gifresize Added GifBase class to inherit resizing commit 6cffcbdf4fca3b00992fc92237330525f85e2681 Merge: 74d77a93 893bccd0 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 21:10:09 2024 -0500 Merge remote-tracking branch 'origin/gifresize' into gifresize commit 74d77a9349ca0cb2f30514c2042822b8678dc52b Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 21:09:51 2024 -0500 cleanup commit 893bccd05192de9729ed6ca16e9325df7b928b58 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri Jan 5 02:07:16 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 7a593db7c4660e4904f02c1f401d8a69557e1591 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 21:05:06 2024 -0500 switch sentry config to IS_RELEASE commit 7f46bc2e08fb3fb8dcd0db63446cca9763658d13 Author: atod <anthony.tod@gmail.com> Date: Thu Jan 4 19:51:12 2024 -0500 start cutting up for gifbase commit 147e3c5b0ddec535a7d367878759ac417e99f542 Merge: 45d95d7e 91cc4424 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Fri Jan 5 10:45:41 2024 +1100 Merge pull request #582 from bigredfrog/adddjbird Add dj bird to keybeat presets commit 45d95d7ec5ea2a20c84f618197cfeb40aeddeb2c Merge: 2743637c f1c06f06 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 4 21:36:48 2024 +1100 Merge pull request #584 from LedFx/deactivate_on_serial_errors Update serial device error handling commit 2743637cb0721c702913f6cdfeb8e382396fbc81 Merge: cc8b9b23 91db3ce6 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 4 21:36:15 2024 +1100 Merge pull request #585 from LedFx/rename_zeroconf Rename zeroconf to mdns_manager commit 91db3ce6148fe8fe810dcb8d040a20bd2111c02d Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 4 21:34:49 2024 +1100 Rename zeroconf to mdns_manager commit f1c06f06c5100fcd38ad0332e3da873334dd3560 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 4 21:12:11 2024 +1100 Fix serial connection interruption - deactivate erroring devices commit b5f7dd925f05ba3836721efafb39bff2613faafd Merge: 1b50aec2 cc8b9b23 Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Thu Jan 4 10:01:57 2024 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit cc8b9b23c6fb25bedc3230c7dfc3fa8fb026c328 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Thu Jan 4 14:58:35 2024 +1100 Migrate to AsyncZeroconf (#581) * WIP * Refactor device discovery using AsyncZeroConf * Fix old comments * Actually finish the comments (its late) * Remove debug asserts * Add GET method to find_devices * Protect POST and cleanup exception handling * Check we have used zeroconf before trying to shut it down commit 91cc442472913c8d3793b751f0a6e23d2ab40fce Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 4 01:58:45 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit e3ece6e852e3ce2b4b4fc9332d228b5e6b1dea70 Merge: 05dea19e 30d81c5c Author: atod <anthony.tod@gmail.com> Date: Wed Jan 3 20:58:25 2024 -0500 Merge remote-tracking branch 'origin/adddjbird' into adddjbird commit 05dea19eedba3245a45577c14f5f10a4bcbf0705 Author: atod <anthony.tod@gmail.com> Date: Wed Jan 3 20:58:11 2024 -0500 Fix up reset for template2d so its easier to debug with and tweak equaliser2d commit 5a80bace1bb8fbeff28b8cb740de07b485beff01 Merge: d3cf5e84 ac14741c Author: Yeon Vinzenz Varapragasam <trusted.yeon@gmail.com> Date: Thu Jan 4 01:09:35 2024 +0100 Merge pull request #583 from LedFx/YeonV-patch-1 Update hiddenimports.py commit ac14741cc7c35d927ada82121b95b1feaa08b9b5 Author: Yeon Vinzenz Varapragasam <trusted.yeon@gmail.com> Date: Thu Jan 4 01:09:20 2024 +0100 Update hiddenimports.py commit 30d81c5c665cd7e4ebaac3558ef47481ddbd1e95 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed Jan 3 23:34:50 2024 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 8aa85c00b470d466e275b7dc7419159b070d5d6d Author: atod <anthony.tod@gmail.com> Date: Wed Jan 3 18:33:24 2024 -0500 Add dj bird to keybeat presets commit d3cf5e8450ef4bfe04ea8901e91c133172e263dd Merge: 5f3aac25 d17a32f6 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Wed Jan 3 18:54:59 2024 +1100 Merge pull request #578 from LedFx/renovate/numpy-1.x-lockfile Update dependency numpy to v1.26.3 commit 5f3aac2507b8a0a43551b37348ea1334712ef264 Merge: 4261b448 a3279034 Author: YeonV <trusted.yeon@gmail.com> Date: Wed Jan 3 03:37:49 2024 +0100 Merge branch 'main' of https://github.com/LedFx/LedFx commit 4261b4485f42b4f27f7610dbee9aef2ec4b58900 Author: YeonV <trusted.yeon@gmail.com> Date: Wed Jan 3 03:37:45 2024 +0100 update presets commit a3279034e79b9132416e3f4acd83967eef347112 Merge: 7383e4a4 05421a53 Author: bigredfrog <anthony.tod@gmail.com> Date: Tue Jan 2 21:26:37 2024 -0500 Merge pull request #574 from shauneccles/gif_player Add GIF Player Effect, Presets and Files commit 05421a53f7217bc13c08eaa30a47b37629aaa988 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Wed Jan 3 12:36:51 2024 +1100 Move timers around commit d17a32f6020877511f1ddffe7e54e05488590c00 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jan 3 00:09:43 2024 +0000 Update dependency numpy to v1.26.3 commit aec9ede016890ccd69838e9bda3edd62996132e5 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Wed Jan 3 10:56:31 2024 +1100 Fix presets, tidy up time_val and rename variables commit 7383e4a4c279528a589aaeb630690472e9bbf4f1 Merge: 29410b42 037a8b39 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Tue Jan 2 22:08:49 2024 +1100 Merge pull request #576 from bigredfrog/gifpass resized to 128 commit 29410b422d9622543d7673992ffaf8433dfad967 Merge: 59fdc84e 5752a85f Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Tue Jan 2 22:08:11 2024 +1100 Merge pull request #575 from LedFx/renovate/pybase64-1.x-lockfile Update dependency pybase64 to v1.3.2 commit 59fdc84eaa7d05c631bd1e238f52d0d47f7c986e Merge: 4da3191d 9c67287f Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Tue Jan 2 22:07:12 2024 +1100 Merge pull request #577 from LedFx/renovate/pillow-10.x-lockfile Update dependency pillow to v10.2.0 commit 71e4b355dc57205fab45d27de810faf0cb5fbded Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Tue Jan 2 21:57:37 2024 +1100 Address comments and mess with timers commit 9c67287f2fa066406bdd7357079915e264a53dbd Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Jan 2 09:31:40 2024 +0000 Update dependency pillow to v10.2.0 commit 037a8b3978dedfa708303ab9c203e4a89e726096 Author: atod <anthony.tod@gmail.com> Date: Mon Jan 1 18:26:33 2024 -0500 resize to min dimension 128 commit 6845a7d453eb1bd1f1555292324438d0a6fe5669 Author: atod <anthony.tod@gmail.com> Date: Mon Jan 1 18:17:43 2024 -0500 resize to min dimension 128 commit f1474b2d89de64cb1bd7a578ac9b34d7dfca88cc Author: atod <anthony.tod@gmail.com> Date: Mon Jan 1 18:15:42 2024 -0500 resize to min dimension 128 commit 82cf96e7d314b24f5c94c8d96a6c171c575323bf Author: atod <anthony.tod@gmail.com> Date: Mon Jan 1 15:03:17 2024 -0500 resized to 128 commit 5752a85f1c884b8e7f9651a886b994df31fb7ad3 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 1 18:27:26 2024 +0000 Update dependency pybase64 to v1.3.2 commit 924eba4ad573b240e8a58a0cd33e7383e02f1156 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Mon Jan 1 17:32:08 2024 +1100 Cleanup comments commit ab4f3361ec0d5eca96bcef26e6a33ff0564166f2 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Mon Jan 1 17:23:55 2024 +1100 Add GIF Player Effect, Presets and Files commit 4da3191d73349ab571f83060ea941e1ecde926ae Merge: a06cd779 e6534c20 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Mon Jan 1 08:30:25 2024 +1100 Merge pull request #572 from shauneccles/test_clone_fix Extra Protection for Clone commit 8cb6ffebc2afbef30d0c8acbf401f9f12417171e Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sun Dec 31 20:21:14 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 2bb4b5e2a6e97ca066db97df5bc53b6fa98b6065 Author: atod <anthony.tod@gmail.com> Date: Sun Dec 31 15:17:39 2023 -0500 Trigger reconfiguration of 2d t_height / t_width against change in rows from virtual config commit e6534c20c0ffdfe402c489b2a3306456af24e95b Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sun Dec 31 12:45:52 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit abd636c75717dc158b3f6d7c550274c8f61a5e12 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sun Dec 31 22:29:07 2023 +1100 Test clone fix commit a06cd7792caa55f35f6afd48b7280e9430564db0 Merge: 16b83047 e5c10bbd Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sun Dec 31 14:12:04 2023 +1100 Merge pull request #570 from bigredfrog/template 2d template commit e5c10bbdeb21d52276971865785708d9a38312fe Author: atod <anthony.tod@gmail.com> Date: Sat Dec 30 21:15:33 2023 -0500 2d template commit 439bce8e65a6197e9938a6b974c54b8ac7a2c7df Merge: 458c1eb8 fe23b763 Author: atod <anthony.tod@gmail.com> Date: Sat Dec 30 21:12:21 2023 -0500 Merge remote-tracking branch 'origin/template' into template commit 458c1eb890c2fc52b6f90181cbfe14e87603fb43 Author: atod <anthony.tod@gmail.com> Date: Sat Dec 30 21:12:03 2023 -0500 2d template commit fe23b763df65e4cb471e01d3f0660266367404ac Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sun Dec 31 00:46:27 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 97e161048b6d3e6d094aa01f52ca9a0b516c5e8b Author: atod <anthony.tod@gmail.com> Date: Sat Dec 30 19:45:36 2023 -0500 2d template commit 16b83047e6ded55cccdd62a4fd8ac6d76b8a882e Merge: b4fe6206 f9f434a0 Author: Shaun Eccles-Smith <shauneccles@gmail.com> Date: Sun Dec 31 11:18:16 2023 +1100 Merge pull request #569 from bigredfrog/luanchpadmini Launchpad mini first cut, inherit for X commit f9f434a037cadf08d2880366f32bb63ad1f54d67 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sat Dec 30 21:12:24 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 8dbe5c31301eebfabf46e2d60c5f05137f777efd Merge: 828ad452 4e1141f6 Author: atod <anthony.tod@gmail.com> Date: Sat Dec 30 16:10:30 2023 -0500 Merge remote-tracking branch 'origin/luanchpadmini' into luanchpadmini commit 828ad452ed2f7489c00f2fd35e191f295695b57f Author: atod <anthony.tod@gmail.com> Date: Sat Dec 30 16:09:21 2023 -0500 change device ID for mini mk3 through device_id substitution commit 4e1141f691fbf0011b3109fd4f51e3e1a1fb60d3 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sat Dec 30 20:53:28 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit b8d3336feadbad3dae522955d66e1a3bd913b261 Author: atod <anthony.tod@gmail.com> Date: Sat Dec 30 15:53:03 2023 -0500 change device ID for mini mk3 through wrapping flush function commit d8e7be2b75bfc06e93b66a10420104463d207f02 Author: atod <anthony.tod@gmail.com> Date: Sat Dec 30 12:14:39 2023 -0500 First cut, inherit for X commit 1b50aec2170d02ac82cdbb1327b33e3a3ea808f1 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sat Dec 16 16:54:00 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit d0547dc06d6e918be964bb59c32bab0b6610f37c Author: mariusCZ <m.cizauskas38@gmail.com> Date: Sat Dec 16 17:53:40 2023 +0100 Switch to pybase64. commit a3d40c6f12dfa7a4219339ebadd27edc1a4bf1f4 Merge: cf369b3b 60b70007 Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Fri Dec 15 09:15:19 2023 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit cf369b3b9ae9aaa4cd970983fe54da1ce82cdd7d Merge: 4d125890 de5cb343 Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Thu Dec 14 09:27:07 2023 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit 4d12589002e70e6c4328b0dcdf536c1cdabfae13 Merge: a8fdc2f0 a0cbb6cf Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Tue Dec 12 10:09:17 2023 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit a8fdc2f01e4f7c0a467f653df5d1cc203496de94 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon Dec 11 13:18:42 2023 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit a6dd786d30d1510a9551a408cc4cf40af4858b04 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Mon Dec 11 14:15:39 2023 +0100 Some exception handling for base64 decoding. commit 0f04544ca53e14c4a74288c804aa555912ac806c Merge: 548d3ab9 fefc4b15 Author: mariusCZ <72140836+mariusCZ@users.noreply.github.com> Date: Mon Dec 11 13:46:47 2023 +0100 Merge branch 'LedFx:main' into webaudio-base64 commit 548d3ab95e23ed8031ce661b1705c56b3285b517 Author: mariusCZ <m.cizauskas38@gmail.com> Date: Mon Dec 11 11:51:14 2023 +0100 Add base64 data parsing for webaudio.
Ugly, dirty, poorElegant, nuanced solution to drive around what appears to be a portaudio bug.Leaves audio device open and analysis running for 5 seconds when no effects areusing it and then checks and closes at the end of the timer.
Summary by CodeRabbit
Summary by CodeRabbit