add brightness image adjustment for keybeat

[bigredfrog]

slider from 0.1 to 3

Defaults to 1.0 which = no adjustment

Very useful on video gif images to boost them up

Tried color balance, contrast and sharpness, but not worth the clutter.

Summary by CodeRabbit

• New Features
  • Introduced an optional image_brightness parameter for effects, enhancing image brightness customization with a range from 0.1 to 3.0.
• Enhancements
  • Improved image processing with brightness adjustments to offer more dynamic visual effects.

[coderabbitai]

Walkthrough

The recent update introduces enhancements to the visual effects by incorporating brightness adjustments. A new dependency, PIL.ImageEnhance, is added to facilitate this change. The configuration schema is expanded to include an image_brightness parameter, allowing users to customize the brightness level of post-processed frames. This adjustment is applied in the config_updated method, demonstrating a focused effort to improve visual output customization.

Changes

File(s)	Change Summary
ledfx/effects/keybeat2d.py	Added PIL.ImageEnhance import; introduced image_brightness in CONFIG_SCHEMA; applied brightness adjustment in config_updated method.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 09c5e4f and 87fbb45.

Files selected for processing (1)

• ledfx/effects/keybeat2d.py (4 hunks)

Additional comments: 3

ledfx/effects/keybeat2d.py (3)

• 5-5: The import of PIL.ImageEnhance is correctly added to support the new brightness adjustment feature.
• 32-32: The addition of image_brightness to ADVANCED_KEYS is appropriate, ensuring it's exposed in the UI as an advanced configuration option.
• 107-111: The CONFIG_SCHEMA correctly defines the image_brightness parameter with a default value of 1.0 and a valid range from 0.1 to 3.0. This aligns with the PR objectives.

[coderabbitai]

The implementation of brightness adjustment using ImageEnhance.Brightness in a list comprehension is correct and efficiently applies the user-configured brightness level to all post_frames. However, consider handling potential exceptions that might arise from image processing operations.

Consider wrapping the brightness adjustment operation in a try-except block to handle potential exceptions gracefully, ensuring the application remains robust in the face of unexpected image processing errors.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 87fbb45 and 28eba67.

Files selected for processing (1)

• ledfx/effects/keybeat2d.py (4 hunks)

Files skipped from review as they are similar to previous changes (1)

• ledfx/effects/keybeat2d.py